Albert Lash wrote:
> Did you get a chance to check out the stuff I added to the PSA class? I just
> wanted a nod from you to make sure I was going in the right direction. You
> don't need to work on it at all just review it real quick.
Just glanced at it, and here's a couple notes:
In user_passwordreset.php:
* Don't use $user = $_GET['id']; Use the value from the _GET array instead.
* all the variables in psa should be pre-pended with PSA_, so use
PSA_user or something similar
For the class itself, I did start looking into that a bit more. I
started editing a couple of the functions, so be sure the check over
what I have done.
For sendMailConfirm:
* don't use global statements. Instead, have an array passed that
contains the required variables.
* don't hardcode parameters for the mail message. Let the user pass the
subject, message, etc. so that it can be customized.
* might want to allow the activation link to be sent as a separate array
element so the format can be checked in the function.
* this array would then go into the config.php file so the users can
easily see what the default values are and can easily edit them. In this
case, I don't think it would be necessary to use gettext on the
variables since the user will set them to what they want anyway.
PS - when you reply-all, remove my email address from the to field so I
only get one copy of the message ;)
|
