Currently Minutes module has 2 tabs for sending emails: Notification and Mail.
They send different data but they use the same transport (email) and it is not intuitive or clear for the user the difference between them.
Notification currently sends, when saving, the data of Basic Data and People tabs. The status field isn't working right and the recipients are the users with read access (default behaviour for notification) instead of people defined in People tab.
Mail tab sends, when pressing 'Send' button an email with the data of Items tabs, and an optional PDF attachment with the Basic Data and People tabs info plus the Items tab content. The recipients are the people selected in that tab.
I think there should exist only one tab maybe called Notification that shows the check box instead of the Send Mail button (the Preview could be left there) and maybe other fields like the Additional recipients textbox.
Currently the IndexController of Minutes sends the email using Phprojekt_Mail class, it should be used the current system (Default_Helpers_Save calling Phprojekt_Notification), but maybe some improvements have to be made to Notification strcuture, like allowing attachments.
Log in to post a comment.
