From: Jean-Michel P. <jm....@fr...> - 2002-12-18 15:44:17
|
Dear all, I just installed WebDB which looks very promissing. I would like to join = the=20 project if you need my help. My first impressions : 1) It is recommended to use require_once everywhere in=20 place of include_once, because require_once will cast an=20 error if the required file is not present.=20 =20 2) Also, the configuration file should be tested in index.html,=20 with file_exists(). If the file does not exist, please print a=20 message to explain that the user should copy the installation file.=20 =20 3) Last, the use of <? ?> and <?php ?> is not coherent. On my=20 RedHat 8.0 + Apache 2.0 + Php 4.2, <? ?> is not recognized=20 by http.conf. Of course, it can be configured, but for compatibility reas= ons=20 with code editors, <?php ?> should always be used.=20 4) File paths should be defined using constants like in ADODB with absolu= te=20 file paths. 5) I am quite worried about the melting of HTML + PHP code. There should = be a=20 way to build a complete object oriented interface, without visible HTML c= ode.=20 HTML code should be embedeed in PHP classes... Much cleaner and easier to= =20 maintain. 6) Why use a javascript tree class viewer? On my Linux box, Javascript is= =20 always disabled. Javascript can be replaced by PHP. So why not do it? It = used=20 to be the case in PhpPgAdmin. Great job and great idea to support several databases, this will help=20 migration to PostgreSQL. Cheers,=20 Jean-Michel POURE |