Re: [ppa-dev] ppa51 bug report: pagination on select report

[Szabolcs H. <sz...@gm...>]

Hi all,


another STR is:
1. Select database
2. Select "SQL" tab
3. Make sure that "Paginate results" is checked
4. Execute: SELECT * FROM generate_series(1,100);
5. Click on any of the pagination links (Next, Last,...)
6a. Notice the "could not find the query!!" string on the top of page
6b. Notice that all the rows were fetched


The problem is in Misc::printPages, it couldn't generate a link to
point back to 'display.php'.
Therefore where 'display.php' is included (tables.php and sql.php),
the generated links are pointing
to the original script instead to 'display.php'.

This bug introduced by leaving (optimizing?) out the script name from
printPage's $url/$gets parameter in commit e1a5b9c54f3e.


Phillippe,
if you are interested, then you could try the fix on my bugfix branch
[2] or just apply the attached patch!

ioguix,
as you can see [3], I simply extended the Misc::printPages function
with a "$script" parameter.
Is this hotfix enough good for a Pull Request, or there are nicer and
simpler fix?
Comments and feedbacks are welcome!


Cheers,
Szabolcs



[1]: https://github.com/phppgadmin/phppgadmin/commit/e1a5b9c54f3ea112a0ce5b2f0f3a0ace9583a354#diff-d7a651385f4ca725178b8cccd2bd50ddL533
[2]: https://github.com/xabolcs/phppgadmin/tree/branch-bug-displayphp-shoud-pass
[3]: https://github.com/xabolcs/phppgadmin/compare/branch-bug-displayphp-shoud-pass

On 2013.06.20. 9:53, phb07 wrote:
> Hi all,
>
> One of my customers reported to me a quite severe bug using ppa 5.1.0.
> As it seems to be easily reproductible, here are the steps to see it.
>
> 1) Select a database
> 2) Select a schema and choose the "Tables" tab -> the tables list appears
> 3) For one table having a lot of rows, click on the "Select" button from
> the actions list -> the columns list with its filtering conditions form
> appears
> 4) Select some or all columns to display and click on the "Select"
> button at the bottom of the page -> the selected rows are displayed,
> with pagination links if all rows cannot be displayed at once.
> 5) Click on any of the pagination links (Next, Last,...) -> instead of
> navigating on the results report, we directly go back to the tables list !
>
> Has this never been reported yet ?
> I checked this morning that this bug exists on the current ppa HEAD version.
>
> Best regards.
> Philippe Beaudoin.