Re: [ppa-dev] Fixes to js/database.js

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 29/05/2013 23:41, Karl O. Pinc wrote:
> 1) Remove jQuery 1.8 .toggle() dependency from js/database.js
> 
> This turned out to be really annoying.  See the commit
> message.

Do you have any pointers or more explanations about that ?

> I strongly suspect that this fixes a bug
> that causes js to constantly run, forever, even
> when the refresh seems to be stopped.  Often
> this seems to manifest itself in my browser as
> an alert in the morning that says a script is not
> responding.  On the other hand, maybe some other
> random web page is doing that to me.

I guess it might be random web pages. When I stop the auto-refresh,
using the profiler of firebug doesn't show me anything running.

Another comment about this commit. Why did you add <noscript> tags and
codes ? The current code already take care of this:
  * with no js activated, you just get a simple "refresh" link.
  * with js, the javascript code kicks off after the page and transform
this exact "refresh" link as a switch to start/stop refresh.

> 2) Add style to the links made active by js.

huh, why ? most of our links are not underscored. Why should this one
look different from others ?

> 3) Have refresh happen instantly when "start"
> is clicked.  
> 
> The window.setInterval() docs
> seem to deliberately leave unspecified
> whether the function is called instantly
> or the first call happens after a delay.
> Regardless, this does no harm.  Right?
> It makes my browser more snappy.

Ok for this one, but I don't think I can cherry-pick it right now as it
drift in the miffle of your first patch on this branch.

> 4) Fix bug where clicking on "stop" would
> display an error message.
> 
> This is not a particularly elegant solution,
> but it works.

Sorry, I'm not sure to understand this one, do you have a use case ?

Thank you,

/ioguix