Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 09/06/2013 04:19, Karl O. Pinc wrote:
> Attached is the same patch, only whitespace adjusted
> so as to apply cleanly to HEAD.

Thank you.

FYI, I started some weeks/months ago to review this patch and started
some refactoring. I don't really rmember what exactly.

I'll try to get my code back really soon, wrap my head around, and
report here so you guys can keep going with this patch if you don't mind.

As I reported unofficially, I'll not spend a lot of time in PPA code
next few month, but I'll stay around to review if/when necessary.

cheers,

> 
> I've not yet otherwise looked at it.
> 
> On 04/21/2013 11:06:02 AM, phb07 wrote:
>> Hi all,
>>
>> Has someone had a look on the patch I proposed some months ago ?
>>
>> Thanks by advance.
>> Philippe.
>>
>> -------- Message original --------
>> Sujet: 	Patch for ALTER TABLE CLUSTER ON
>> Date : 	Thu, 27 Dec 2012 12:33:09 +0100
>> De : 	phb07 <ph...@ap...>
>> Pour : 	php...@li...
>>
>>
>>
>> Hi all,
>>
>> Under my Christmas Tree, I have found the attached patch ;-).
>>
>> As far as I can understand, it adds a capability to the alter table
>> functionality, namely to specify, change or remove a clustered index
>> definition.
>> It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and "ALTER
>> TABLE SET WITHOUT CLUSTER" sql statements.
>>
>> The patch should apply on the HEAD.
>> It only works for postgres version >= 8.0 as 7.4 doesn't support the
>> SET
>> WITHOUT CLUSTER clause.
>>
>> Unfortunately, Christmas Father has not tested this patch with pg7.4.
>> He has not included additional Selenium regression test too (he is 
>> not
>> yet familiar with this nice tool ;-)).
>>
>> Let me know what you think about this patch (as a first patch
>> supplied,
>> it may need some refinements). I will forward to its author...
>>
>> With my best wishes,
>> Philippe Beaudoin (beaud76)