Re: [ppa-dev] Patches for ppa self-tests

[Karl O. P. <ko...@me...>]

On 06/06/2013 07:30:41 PM, Karl O. Pinc wrote:
> On 06/06/2013 05:23:30 PM, Jehan-Guillaume (ioguix) de Rorthais 
> wrote:
> > On 20/05/2013 23:53, Karl O. Pinc wrote:
> > > On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais
> > wrote:
> > >> On 30/04/2013 21:57, Karl O. Pinc wrote:
> > > 
> > >>> https://github.com/kpinc/phppgadmin/commits/selenium-login
> > >>>
> > >>> 1 patch.
> > >>> Deletes cookies on selenium login so that previous
> > >>> failed or paused tests do not affect the execution of
> > >>> subsequent manually executed tests.  This allows
> > >>> the user more control over manual test execution.

> > I was just opposing syntaxes. I prefer the following form because 
> > it's
> > more consistent with other methods:
> > 
> >   $this->deleteAllVisibleCookies();
> > 
> > "$this->test(...)"  method should be used for ... tests :)

It's not consistent with other methods.  E.g. login contains:

            $this->test('open', "{$this->webUrl}/intro.php");

not:
	$this->open("{$this->webUrl}/intro.php");

I want to clear cookies during tests (repeatedly).

If cookies were to be cleared only once when the selenium
page is entered then login is the wrong place to put
$this->deleteAllVisibleCookies();
because login gets called multiple times, all
at the time the selenium page is entered.

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein