|
From: Karl O. P. <ko...@me...> - 2013-06-07 00:30:51
|
On 06/06/2013 05:23:30 PM, Jehan-Guillaume (ioguix) de Rorthais wrote: > On 20/05/2013 23:53, Karl O. Pinc wrote: > > On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais > wrote: > >> On 30/04/2013 21:57, Karl O. Pinc wrote: > > > >>> https://github.com/kpinc/phppgadmin/commits/selenium-login > >>> > >>> 1 patch. > >>> Deletes cookies on selenium login so that previous > >>> failed or paused tests do not affect the execution of > >>> subsequent manually executed tests. This allows > >>> the user more control over manual test execution. > >> > >> I don't like this. > >> > >> I prefer this syntax: > >> > >> $this->deleteAllVisibleCookies(); > > > > I'm not sure I understand. Your suggestion would > > delete all cookies when the Selenium test suite > > is entered, right? > > I was just opposing syntaxes. I prefer the following form because > it's > more consistent with other methods: > > $this->deleteAllVisibleCookies(); > > "$this->test(...)" method should be used for ... tests :) > > So, in the diff of function login, I would prefer to see: > > $this->deleteAllVisibleCookies() > > instead of: > > $this->test('deleteAllVisibleCookies'); But it's not a difference in syntax it's a difference in semantics. $this->deleteAllVisibleCookies() deletes the cookies whenever the selenium self-test link is clicked from intro.php. Whereas $this->test('deleteAllVisibleCookies') deletes all cookies during the self-test runs every time the self-test suite logs a user in. The latter resets the self-test browser side environment many times during the self-test suite execution to ensure a consistent environment for each test. This is what I think is needed. Regards, Karl <ko...@me...> Free Software: "You don't pay back, you pay forward." -- Robert A. Heinlein |