Re: [ppa-dev] Patches for ppa self-tests

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 20/05/2013 23:53, Karl O. Pinc wrote:
> On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 30/04/2013 21:57, Karl O. Pinc wrote:
> 
>>> https://github.com/kpinc/phppgadmin/commits/selenium-login
>>>
>>> 1 patch.
>>> Deletes cookies on selenium login so that previous
>>> failed or paused tests do not affect the execution of
>>> subsequent manually executed tests.  This allows
>>> the user more control over manual test execution.
>>
>> I don't like this.
>>
>> I prefer this syntax:
>>
>>   $this->deleteAllVisibleCookies();
> 
> I'm not sure I understand.  Your suggestion would
> delete all cookies when the Selenium test suite
> is entered, right?

I was just opposing syntaxes. I prefer the following form because it's
more consistent with other methods:

  $this->deleteAllVisibleCookies();

"$this->test(...)"  method should be used for ... tests :)

So, in the diff of function login, I would prefer to see:

  $this->deleteAllVisibleCookies()

instead of:

  $this->test('deleteAllVisibleCookies');