Re: [ppa-dev] Patches for ppa self-tests

[Robert T. <ro...@xz...>]

On Mon, May 20, 2013 at 5:53 PM, Karl O. Pinc <ko...@me...> wrote:
> On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 30/04/2013 21:57, Karl O. Pinc wrote:
<snip>
>> > 3 patches.
>> > Internationalizes the selenium link on the ppa intro page.
>> > Makes the link "hot" only when selenium has been configured.
>>
>> These two patch seems useless to me: we remove the selenium links
>> before
>> each release of PPA. This would require to remove the i18n as well.
>
> Yes...  But this last release selenium was not removed.  It seems
> useful to be able to run the test suite on released code
> as an end-user.
>

why? I asked some end users, none of them could see any value in it. I
thought about the software I run, I can't think of any that ships with
a test suite, nor any i would run. I think this would be different if
the test were testing for system dependencies or something, but that
isn't what they do.

So, after thinking about this, I like the idea of the disable link
based on config, but I'd still want to remove it all in final release.

> There could be issues, in which case yes these patches are useless.
> See my response to Robert regards this.
>
> It now occurs to me that people run HEAD a lot.  If it's dangerous
> to have the self-tests on a production system we should probably
> address this.
>

I have sometimes recommended people try head if they are trying to
verify a problem or some such, but I think the expectation is if
you're pulling from git, there's no guarantees from us that anything
will work or be safe (and yes, I personally run head all the time, but
for client stuff, I tell people to install releases)

> P.S.  Where is the code that creates the release?

http://phppgadmin.cvs.sourceforge.net/viewvc/phppgadmin/project/release.sh?revision=1.9&content-type=text%2Fplain

I actually thought I had fixed some other issue with it during the
last release, but that should pretty much work, barring OS difference
like my sed :-\

Robert Treat
play: xzilla.net
work: omniti.com