Re: [ppa-dev] Patches for ppa self-tests

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 30/04/2013 21:57, Karl O. Pinc wrote:
> Hi,
> 
> I've a number of patches for inclusion into ppa.
> I thought, rather than attach them here, I'd
> link to the branches on github and describe them.
> 
> If this isn't a good process then please let me
> know what works better.
> 
> 
> https://github.com/kpinc/phppgadmin/commits/selenium-login
> 
> 1 patch.
> Deletes cookies on selenium login so that previous
> failed or paused tests do not affect the execution of
> subsequent manually executed tests.  This allows
> the user more control over manual test execution.

I don't like this.

I prefer this syntax:

  $this->deleteAllVisibleCookies();

> https://github.com/kpinc/phppgadmin/commits/selenium-enabled
> 
> 3 patches.
> Internationalizes the selenium link on the ppa intro page.
> Makes the link "hot" only when selenium has been configured.

These two patch seems useless to me: we remove the selenium links before
each release of PPA. This would require to remove the i18n as well.

> Adds a "reset" link to clean cruft from failed self-test runs.

This one definitely worth it! Thanks to this, we could open Both normal
and reset scenario in two different tabs and switch between them.

+1, but could you make some cleanup first about i18n please?

> https://github.com/kpinc/phppgadmin/commits/selenium-doc
> 
> 4 patches.
> Changes to tests/selenium/README to make it more better.
> The last patch documents the "reset" link above.

+1

> https://github.com/kpinc/phppgadmin/commits/gitignore
> 
> 1 patch.
> Frob .gitignore to ignore emacs backup files.

Well, you can use the file ".git/info/exclude" or the one you specify
through "core.excludesfile".

I already use the first one to deal with my own
backup/tests/config/plugins files.

Thank you Karl,

> Regards,
> 
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein