Menu
▾
▴
[ppa-help] [ phppgadmin-Bugs-3420712 ] Auto complete does not work for foreign key constraints
|
From: SourceForge.net <no...@so...> - 2012-11-28 04:49:53
|
Bugs item #3420712, was opened at 2011-10-08 22:53 Message generated for change (Settings changed) made by xzilla You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=418980&aid=3420712&group_id=37132 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Constraints Group: 5.0.3 >Status: Pending >Resolution: Fixed Priority: 5 Private: No Submitted By: Brandon Phelps (brandonnc83) Assigned to: Robert Treat (xzilla) Summary: Auto complete does not work for foreign key constraints Initial Comment: When a foreign key constraint exists and you are inserting a record from the web gui, selecting an option from the popup inserts "<div style="text-align: right; background-color: rgb(61, 128, 223); color: rgb(255, 255, 255);">ID</div>" into the input box instead of just the ID. This obviously results in an SQL query if you submit. Using Firefox 7.0.1 and PostgreSQL 9.1 with phpPgAdmin 5.0.3. ---------------------------------------------------------------------- Comment By: Robert Treat (xzilla) Date: 2012-11-27 20:49 Message: This is fixed in my local repo and will be merged into the official repo shortly, on the master branch. You can get the immediate fix at https://github.com/xzilla/phppgadmin/commit/bcf3cae0584becfd6cba7bf7b97fd166c97ab392 If you could test and confirm this fixes your issue, that would be great. Thanks for the bug report. ---------------------------------------------------------------------- Comment By: Nate Bessette (frickenate) Date: 2012-06-26 18:51 Message: Just ran into this bug, quite annoying. jQuery will handle this for you: jQuery('input[name="values['+ a[i].name +']"]').val(jQuery(a[i]).text()); ---------------------------------------------------------------------- Comment By: J.Guillaume (ioguix) de Rorthais (ioguix) Date: 2012-01-24 09:26 Message: Hey, Thank you for reviving this bug... I'm currently pretty almost alone "working" on PPA on my free time right now and I have so much to do with the plugin arch presently. Anyway, I'll try to fix this bug in our current dev tree as soon as possible... Cheers! ---------------------------------------------------------------------- Comment By: woodz (woodz_) Date: 2012-01-14 15:14 Message: Hi guys, I was digging a bit deeper since I absolutely want that feature working well. I found out that the provided solution from vicpopov does not work for Mozilla Firefox. You can check http://www.davidtong.me/innerhtml-innertext-textcontent-html-and-text/. They link to the dom/w3c and there is a cross browser replacement given: var text = x.innerText || x.textContent; FF does not know about innerText, it just knows textContent. By the way I do not understand why the funky browser manufacturers can't have a standard between in 2012? So I suggest to extend our workaround to: With context: replace string jQuery('input[name="values['+ a[i].name +']"]').val(a[i].innerHTML); with jQuery('input[name="values['+ a[i].name +']"]').val(a[i].innerText || a[i].textContent); Die-hard ppa developers may consider the further workarounds mentioned under the resource above, especially when keeping white spaces is required when doing inline editing. Good night ---------------------------------------------------------------------- Comment By: J.Guillaume (ioguix) de Rorthais (ioguix) Date: 2011-11-10 10:51 Message: Hello, Thank you for the report, patch proposal and feedback ! I'll try to review / commit this as soon as possible, probably on next week. ---------------------------------------------------------------------- Comment By: Xiguang Wang (kurapicapku) Date: 2011-11-10 05:33 Message: I've tryed vicpopov's patch and it does work. Not found any other problem caused by the patch yet. ---------------------------------------------------------------------- Comment By: Victor Popov (vicpopov) Date: 2011-10-26 03:34 Message: Quick fix, not sure if it is absolutely correct: replace occurence of "InnerHTML" text in file js/ac_insert_row.js (there is only one such) with "innerText". With context: replace string jQuery('input[name="values['+ a[i].name +']"]').val(a[i].innerHTML); with jQuery('input[name="values['+ a[i].name +']"]').val(a[i].innerText); ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=418980&aid=3420712&group_id=37132 |
