#349 Doesn't check if pg_dump_path is valid

CVS
closed-fixed
5
2009-03-11
2009-02-16
porneL
No

If value of pg_dump_path setting isn't correct, export fails with:

<b>Notice</b>: Undefined offset: 1 in <b>…/phpPgAdmin-4.2.2/dbexport.php</b> on line <b>75</b><br />

dbexport.php should check if exec() succeeded.

Also in default config suggested pg_dump_path is 'C:\\Program Files\\PostgreSQL\\8.0\\bin\\pg_dump.exe'. I think simple 'pg_dump' would be a safer choice (working on all platforms if PATH is set appropriately).

Discussion

  • J.Guillaume (ioguix) de Rorthais

    • milestone: 897043 --> CVS
    • assigned_to: nobody --> ioguix
     
  • J.Guillaume (ioguix) de Rorthais

    • status: open --> closed-fixed
     
  • J.Guillaume (ioguix) de Rorthais

    This issue has been resolved and is currently fixed in our GIT repository.

    If you wish to acquire the fix, please download the snapshot from the
    following page by clicking on the "download" button on the right of the
    "watch" one: http://github.com/xzilla/phppgadmin/tree/master

    Thanks for your report !

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks