#245 phppgadmin with php-4.4.0 complains that only variable refer

[valli]

After upgrading to php-4.4.0 and pgadmin 3.5.3, the
following message is printed
in the database selection frame:

Notice: Only variable references should be returned by
reference in
/.../htdocs/phpPgAdmin/classes/database/Postgres80.php
on line 74

[Ryan Cavicchioni]

Logged In: YES
user_id=1314626

This notice exists in phpPgAdmin 3.5.4 with PHP 4.4.0 as
well. To fix this, I edited line 10 libraries/lib.inc.php.
Currently the line reads as "error_reporting(E_ALL);" I
changed it to "error_reporting(E_ALL & ~E_NOTICE);"

This will disable the display of PHP notices while running
phpPgAdmin.

If this does not work for you, open your php.ini file and
verify that error_reporting = E_ALL & ~E_NOTICE.

Hope this simple fix helped.

Regards,
Ryan

[Chan Min Wai]

Logged In: YES
user_id=402754

This Just cuppress the error don't really get the problem
off phppgadmin.

Any other way to solved?

[Christopher Kings-Lynne]

Logged In: YES
user_id=82305

Fixed for 3.5.5 and 4.0 in CVS.

[Michael Bennett]

Logged In: YES
user_id=827302

I am still getting this in 3.5.5 with PHP 4.4.0. Not sure how it is fixed.

Notice: Only variables should be assigned by reference in /Volumes/
FL4Data/www/sites/FlySecure/a/pgAdmin/browser.php on line 210

Notice: Only variables should be assigned by reference in /Volumes/
FL4Data/www/sites/FlySecure/a/pgAdmin/all_db.php on line 195

Notice: Only variables should be assigned by reference in /Volumes/
FL4Data/www/sites/FlySecure/a/pgAdmin/database.php on line 656

Notice: Only variables should be assigned by reference in /Volumes/
FL4Data/www/sites/FlySecure/a/pgAdmin/tables.php on line 533

[valli]

Logged In: YES
user_id=1069142

As ashpool7 noticed, this error ist not fixed properly.
=> Reopen the Bug

[Travis Cline]

Logged In: YES
user_id=1207249

A (the?) solution is to not return the result of a function
directly -- afaik.

i.e. from line 74 in Postgres80.php
return $this->selectSet($sql);

would become
$result = $this->selectSet($sql);
return $result;

good info from valiant of Gallery2 here:
http://gallery.menalto.com/node/33076

There are many instances of this so changing the error
reporting level is the ideal short-term solution.

I'd be happy to provide a diff if a dev doesn't want to find
them (him|her)self.

tclineks

[valli]

Logged In: YES
user_id=1069142

Fixed in 3.5.6
=> Closed the Bug