#92 Join command still not functioning

1.94
closed
1
2014-05-04
2014-05-01
Anonymous
No

The join command, which says has been fixed in the bug notes, still doesn't work. Says invalid command. Rendering this build useless for what I need. Any ideas on how to fix this issue? I tried commenting out the JS quick validation, no go.

Discussion

  • Jordan T

    Jordan T - 2014-05-01

    Woops, wasn't logged in. Post by me.

     
    • Ciprian Murariu

      Ciprian Murariu - 2014-05-01

      http://ciprianmp.com/plus/ - the demo is working fine.
      Send me a link to your chat so I can visit and replicate.

      PS: the validation is in lib/commands.lib.php - if you wish to look into it yourself.

       
      • Jordan T

        Jordan T - 2014-05-02

        Did you actually try the /join command? I've tried now on every browser that is available, here in 2014, it doesn't work man....

         
  • Jordan T

    Jordan T - 2014-05-01

    I have looked, the command is there, and regex should be fine. It's the JS validator that's throwing the prompt and preventing submit. I'll have to move the chat to a host, it's currently offline. Give m a bit.

    Update: It should be available at http://wasasquatch.strangled.net/PHPMyChat/

     
    Last edit: Jordan T 2014-05-01
  • Jordan T

    Jordan T - 2014-05-01

    And like I said, I commented out the entire JS quick validator in index.lib.php but it still prompts the same message and doesn't submit.

    Update: Turned off required registrations

    Could this be a Google Chrome issue with JavaScript? If so, that's bad.

     
    Last edit: Jordan T 2014-05-01
  • Jordan T

    Jordan T - 2014-05-02

    I tried your demo, it also does not let you use /join as it should (join a room or create it), this must be a incompatibility with Google Chrome.

    This is interesting considering PHPMyChat (the original build, like this modified version http://nexxushost.com/rpg/thekeep) allows you to use it just fine, and it's the same legacy JS as far as I know in that modified version.

    Edit: Actually, doesn't work in Firefox either. Lol

    Firefox

    Chrome

    I've tried creating rooms, with, and without passwords, I've tried going to public rooms, nothing works with the command what so ever.

     
    Last edit: Jordan T 2014-05-02
    • Ciprian Murariu

      Ciprian Murariu - 2014-05-02

      You are wrong. It works just fine on my end with Chrome. I am sure it works with any other browser as well.
      Are you sure your browser settings allow javascript to be run?
      That's the only reason I could think of right now.
      The command format is:
      /join 1 #room name
      Or
      /join 0 #room name
      (Last for private rooms)

      It allowed me to create new rooms as well as joining existing ones. Something is wrong on your end only... Sorry.

       
      • Jordan T

        Jordan T - 2014-05-02

        Oh, you killed the join command. What the heck is that nonsense? Deliminating one or zero for private? The password took care of that. So there is essentially no custom user rooms anymore of appropriate nature where only certain people with the pass can join? Lol

        You have to remember, humans are typing the commands. Not a machine, they won't automatically understand the 1 or 0, even by reading the directions. They want to use plain english, hence english/language based commands.

        I might just need to update the original PHPMyChat. You've sort of butchered the chat. :\

        While expecting donations and plastering copyrights and donation links all over the chat, which is originally a completely free chat to do with as you please, include removing any copyright notice. Kinda going against the the reason PHPMyChat was included in WHM and cPanel in the past.

        You might want to note there is no custom private rooms anymore, only public private rooms to those users with super perms. Anyone with those perms can access any private room. No more meeting rooms, secret hideouts, just straight open to any of those users.

         
        Last edit: Jordan T 2014-05-02
    • Ciprian Murariu

      Ciprian Murariu - 2014-05-02

      Here it is: http://ciprianmp.com/plus/lurking.php
      ... Proof I was there. Even from Chrome on my HTC One...

       
    • Ciprian Murariu

      Ciprian Murariu - 2014-05-02

      And your own setup is working just fine, so stop messing with the code before you make sure it's a bug.... Lol
      http://wasasquatch.strangled.net/PHPMyChat/lurking.php
      I have created that room using join in your chat.

       
      • Jordan T

        Jordan T - 2014-05-02

        Tell ya what, if you didn't re-write (hack) the code on 10 different pages, it wouldn't be so easy to break. Lol. It should be one function/class called on each or one page, not code rewriting whats been done elsewhere.... Leaving one to track the data across a plethora of files to find which one is altering the string with what. Lol

         
        Last edit: Jordan T 2014-05-02
  • Jordan T

    Jordan T - 2014-05-02

    Sorry to be offensive, I realize I'm being rude. But I'm just now realizing everything that was PHPMyChat is being phased out and called "Plus" plus means it's an addition of things, not really changing things into a completely different feature.

     
  • Ciprian Murariu

    Ciprian Murariu - 2014-05-03

    I really don't see your point... You reported a bug which is not a bug, then going mad you saw code is not the same after 14 years, in a totally modified version. Plus has been tremendously extended with new features and php5/6 compatibility, while still keeping the old behaviour/usage of commands.
    Can you please go private with me on this?
    Besides, I can see you've used the standard version so long that you're kinda addicted to it. Tell ya what: use the plus version for a few months, see what brought new to you, find things that are not working as it should, then make a list of wishes. Jumping into criticizing before you even use the new plus, I give you that, it is a little impolite. I like critics, if they are constructive.
    What do you mean by 1/0 delineation? It was always like that. Read the help/tutorial before saying something is broken.
    Please be aware that the demo you sent me earlier in this thread (the role play site) might be using the std version, but it was intensively modified, as I can see in the footer credits, to include a duferent piece of chat software. So that chat is not a good exemple to compare things out, as it's not phpmychat anymore.
    What pho version does that server use? It might not even be upgraded to the latest one.
    Btw, the std version is still there for download, that the curtoasy to our fellows who first designed it (Php Heaven Team).

     
    • Ciprian Murariu

      Ciprian Murariu - 2014-05-03

      As for using classes, I am looking forward to having your help on that.
      Oh, you might want to help me make it AJAX & html5, and also having a few clients (android/ios - touch wise approached). How about that? ;)

      PS: imagine how messy was for me to track down the std code developed by 7 different people initially. But I've done it through thousands of hours spent on plus. And I really enjoyed it, never complained about it. All my respect to the 2001 team! :)

       
      • Jordan T

        Jordan T - 2014-05-03

        I remember having to do these edits on the original PHPMyChat, is was not easy. I've had to do this three times now because I never released my code (or stored it online) the only gripe I have is that private rooms are essentially public to registered users/staff. Originally they were intended for any registered user, to create a room via /join RoomName {Pass} where the password was optional, entering a pass made a private room, without it, a public room. Other users could not access that room without that same command (essentially entering in the password to enter said room) And seeing it completely different completely foiled my plans for the chat I was going to use. Leaving me with my first option... writing a new chat. -__-

        Again, I apologize, but my world ended last couple days (I am having to rebuild an entire community from scratch no thanks to 1&1)

         
        Last edit: Jordan T 2014-05-03
        • Ciprian Murariu

          Ciprian Murariu - 2014-05-03

          Just a short additional hint:
          Plus has now the so called Restricted rooms, for which the admin sets access to individual reg users in admin panel.
          Those rooms are public but with restricted access. No need for more passwords than the login one. Try it. :)

           
          Last edit: Ciprian Murariu 2014-05-03
  • Ciprian Murariu

    Ciprian Murariu - 2014-05-03

    Can we close down this fake bug report now? Thank.
    You have my private email, I will be waiting for your collaboration.

     
    • Jordan T

      Jordan T - 2014-05-03

      Yes you can, if you can delete it, feel free. I responded t you above as well. If you have Skype add wasasquatch, I don't frequent email much.

       
  • Ciprian Murariu

    Ciprian Murariu - 2014-05-03

    Are you sure the join command had ever been using that format with passwords? I never changed that command. As far as I remember, private rooms were created with 0 then the creator can send invites with /invite username. Using passwords might be from a different software... Try this pure std chat: http://ciprianmp.com/std/
    Now that you mentioned it, I might think of implementing a password join approach as well :)

     
  • Ciprian Murariu

    Ciprian Murariu - 2014-05-03
    • status: open --> closed
    • private: No --> Yes
     
  • Ciprian Murariu

    Ciprian Murariu - 2014-05-03

    Not a bug report but a feature request.

     
  • Ciprian Murariu

    Ciprian Murariu - 2014-05-04
    • private: Yes --> No
     


Anonymous

Cancel  Add attachments





Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks