#753 Updating table content in table view does not work

closed-works-for-me
nobody
None
5
2013-01-18
2012-07-19
No

1) Install phpMyAdmin 3.5.2 (I did it on Win7 32bit using EasyPHP (PHP 5.4.4 VC9 | Apache 2.4.2 VC9 | MySQL 5.5.25a | PhpMyAdmin 3.5.1 | Xdebug 2.2.0))
config.inc.php does not need to be present.
2) Create a table which has a primary key.
3) Add some table rows.
4) Switch to "Browse view" of table ("SELECT * FROM `mytable` LIMIT 0 , 30")
5) Try to edit a value by clicking on it and pressing enter.

Result: Nothing happens. Edited field not saved.
Instead Firebug reports:
a is undefined
return decodeURIComponent(a.replace(/\+/g, "%20")) in sql.js
Chrome says:
Uncaught TypeError: Cannot call method 'replace' of undefined

Problem seems to be that the layout (HTML) changed, while JS still search for old ids and classes.
I attached fixed versions of the two concerned files.

Discussion

  • NotDifficult

    NotDifficult - 2012-07-19
     
  • Marc Delisle

    Marc Delisle - 2012-07-19
    • milestone: 3018536 -->
     
  • Marc Delisle

    Marc Delisle - 2012-07-19

    Moved to Patches.

     
  • Marc Delisle

    Marc Delisle - 2012-07-19
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2012-07-19
    • status: open --> pending
     
  • Marc Delisle

    Marc Delisle - 2012-07-19

    Hi,
    thanks for your report. I have two problems with it, however:
    1. I cannot reproduce this problem with 3.5.2 under Chrome 20.0.1132.57
    2. I cannot see your changes, since you have used the minified .js files and somehow have introduced newlines and tab characters in them

    Could attach here a small export of your test table so I can at least try to reproduce the bug?

    Also, are you familiar with git and github? With this, you could clone our repository, modify your version and issue a pull request so we can correctly see the changes you propose.

     
  • NotDifficult

    NotDifficult - 2012-07-19
     
  • NotDifficult

    NotDifficult - 2012-07-19
    • status: pending --> open
     
  • NotDifficult

    NotDifficult - 2012-07-19

    Just updated to Chrome 20.0.1132.57 still same problem here. I'll attach an export of my db.
    I'll also attach diffs of the edited files. They are really minor.

     
  • NotDifficult

    NotDifficult - 2012-07-19
     
  • NotDifficult

    NotDifficult - 2012-07-19
     
  • NotDifficult

    NotDifficult - 2012-07-19

    Added screenshot showing the problem.
    I just pressed enter which caused the last error:
    Uncaught TypeError: Cannot call method 'replace' of undefined sql.js:3
    PMA_urldecode sql.js:3
    (anonymous function) makegrid.js:672
    b.extend.each jquery-1.6.2.js:23
    b.fn.b.each jquery-1.6.2.js:16
    PMA_makegrid.a.postEditedCell makegrid.js:668
    PMA_makegrid.a.saveOrPostEditedCell makegrid.js:928
    PMA_makegrid.a.initGridEdit makegrid.js:1079
    rb jquery-1.6.2.js:4
    c.event.handle jquery-1.6.2.js:65
    c.event.add.g.handle.l jquery-1.6.2.js:59

     
  • NotDifficult

    NotDifficult - 2012-07-19
     
  • Marc Delisle

    Marc Delisle - 2012-07-21
    • assigned_to: lem9 --> nobody
    • status: open --> pending
     
  • Marc Delisle

    Marc Delisle - 2012-07-21

    Hi,
    I saw your screenshot but I still cannot reproduce your problem (but I'm testing on Vista).

    You did not answer about your familiarity with git and github.

     
  • Marc Delisle

    Marc Delisle - 2012-07-21

    Another question: did you try disabling all your Chrome extensions?

     
  • Marc Delisle

    Marc Delisle - 2013-01-18
    • status: pending --> closed-works-for-me
    • milestone: --> Basic_idea,_not_for_release
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks