#744 (ok 4.0) Fix bug#3415061 login screen appear under the page

closed-fixed
1
2013-05-09
2012-04-11
No

Fixed the problem of login screen appearing under the page after session expire in a newly opened SQL tab.
Probably the fix is one of the easiest ways to fix this bug and proper solutions might include checking for JSON/non-JSON AJAX response, but I think the fix may suffice at the moment.

Discussion

  • Marc Delisle

    Marc Delisle - 2012-04-12
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2012-04-12

    Atul,
    I would like to apply your patch but first I am trying to reproduce the problem and I cannot. Which phpMyAdmin version are you using?

    Which browser?

     
  • Atul Pratap Singh

    Marc,
    I am using latest Git master, browser is chrome. Problem is present in firefox also.
    Steps:-
    1. Open a SQL window in a new tab, and wait for the session to expire.
    2. Now try to execute a query by clicking at 'Go'.
    3. You will notice the login window at the bottom of the same page.
    No redirection happens as window.top and window.self are same in a separately opened tab.

     
  • Atul Pratap Singh

    I am also able to reproduce it on latest master demo server(Configured for cookie auth....).

     
  • Marc Delisle

    Marc Delisle - 2012-04-12

    Atul,
    what do you mean "in a new tab"? Do you refer to the distinct query window opened via the third top icon in the navi panel?

     
  • Atul Pratap Singh

    Marc,
    Its not the top icon in the navi panel, please open the content frame's SQL link (besides the Databases/Structure link) by right clicking and 'Open in a new tab'.

     
  • Marc Delisle

    Marc Delisle - 2012-04-12

    Patch accepted, thanks. See also my commit 6557b71b88fe19997844169854d34af73a02c70f.

     
  • Marc Delisle

    Marc Delisle - 2012-04-12
    • priority: 5 --> 1
    • summary: Fixing bug#3415061 login screen appear under the page --> (ok 4.0) Fix bug#3415061 login screen appear under the page
    • status: open --> open-accepted
     
  • Atul Pratap Singh

    @marc
    Thanks for making me aware of CDATA related XHTML rules. :)

     
  • Michal Čihař

    Michal Čihař - 2013-05-09
    • Status: open-accepted --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks