#739 wecan either use the static method in the code in order to i

closed-rejected
nobody
5
2012-04-04
2012-04-03
No

we can either use the static method in the code in order to improve theefficiency.
another point I would like to ask what if we use the complete pathname with
require and include, it will be much faster.

Discussion

  • nandlal ahirwar

    nandlal ahirwar - 2012-04-03

    wecan either use the static method in the code in order to improve the > efficiency. > another point I would like to ask what if we use the complete pathname with > require and include, it will be much faster.

     
  • Rouslan Placella

    Not sure what to make of your patch. Could you, maybe, explain further what you are trying to accomplish?

     
  • Rouslan Placella

    • status: open --> pending
     
  • nandlal ahirwar

    nandlal ahirwar - 2012-04-04

    PHP code mixed with HTML tags will basically cause crash, "strip_tags" to strip every html and php tags
    in $var, every characters after "<" is removed.
    i think strip_tags() is mixed up.

    we often get error:tbl_replace.php: Missing parameter when adding i.e. entries into mysql from within
    phpmyadmin chences of having issue with cookies on the system, i.e.if disabled cookies in the browser
    this can be changed.
    Instead of using the elseif statements code can be reduced with
    <script>
    <?php
    switch($anyval){ ?>
    $(document).ready(
    function (){
    <?php case 1: //?>
    <?php case 2: //?>
    <?php case 3: //?>
    })
    <?php }?>
    </script>

    wecan either use the static method in the code in order to improve the
    efficiency.
    another point I would like to ask what if we use the complete pathname with
    require and include, it will be much faster.

    / this can be inside libraries/common.inc.php
    define('__ROOT__', dirname(dirname(__FILE__)));
    // then other scripts use this
    require_once(__ROOT__.'/foo.php);

    So we could define __ROOT__ once and use it afterwards. One thing I'm
    not sure about: we prefixed with './' to help in open_basedir case.
    we would have to test this case.

     
  • Rouslan Placella

    I still have no idea what you are talking about. The are only a few occurences of strip_tags() in our code base, none of them are in common.inc.php (which your patch is for) and none of them get any PHP code as input....

    In any case, the patch tracker is hardly the correct place to discuss this. If you are experiencing a particular issue in PMA, you can file a bug for it. Or, if you just wish to discuss a concept, please use the developers mailing list for this.

     
  • Rouslan Placella

    • status: pending --> closed-rejected
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks