True, dont get me wrong, but I think phpmyadmin is a lot over configurable. The $force_text argument should also be removed and the function split in two, because flag arguments is not that good.
This was also a test to see if my code would be accepted. I have never contributed to an open source project before.
It is too much output on the webpage. imho, to make phpmyadmin a lot nicer, there should be less output and the frameset needs to be removed. Ajax can also be used to keep load times down.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The text was enabled by default in 3.3 (I think), because novice users had troubles recognizing what do the icons mean. It is indeed too verbose for experienced users, that's why this can be enabled. And even though I agree there is way too much to configure in phpMyAdmin, this is thing you can configure in almost any GUI.
I don't see benefit in duplicating the code to remove the $force_text argument ...
Frames removal is currently not really possible as long as we want to keep at least minimal support for users without javascript.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Tooltips are good for explaining an icon. I dont like how icons got collapsed in the "more arrow" list although I understand that the introduction of texts made that necessary. Actually, I can see the list flash before my eyes when I load the webpage.
Flag arguments is an excuse for not creating another function with a descriptive name. People can have different opinions about this of course, but the main approach amongst experienced programmers is to avoid them.
Code duplication surely is a bad thing but you dont need to have duplicated code as long as you break out commons in the resulting two functions. A lot of functions is seldom a problem. The real problem is large incomprehensible functions.
Frames can be removed still supporting users without javascript since the logic happens on the server side anyway.
Users that wants to avoid javascript can avoid them using the noscript extension and enable javascript for the sites they trust. (Turning off javascript is so 1998).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
patch
As you could see from code you've removed, this can be configured by PropertiesIconic
True, dont get me wrong, but I think phpmyadmin is a lot over configurable. The $force_text argument should also be removed and the function split in two, because flag arguments is not that good.
This was also a test to see if my code would be accepted. I have never contributed to an open source project before.
It is too much output on the webpage. imho, to make phpmyadmin a lot nicer, there should be less output and the frameset needs to be removed. Ajax can also be used to keep load times down.
The text was enabled by default in 3.3 (I think), because novice users had troubles recognizing what do the icons mean. It is indeed too verbose for experienced users, that's why this can be enabled. And even though I agree there is way too much to configure in phpMyAdmin, this is thing you can configure in almost any GUI.
I don't see benefit in duplicating the code to remove the $force_text argument ...
Frames removal is currently not really possible as long as we want to keep at least minimal support for users without javascript.
Tooltips are good for explaining an icon. I dont like how icons got collapsed in the "more arrow" list although I understand that the introduction of texts made that necessary. Actually, I can see the list flash before my eyes when I load the webpage.
Flag arguments is an excuse for not creating another function with a descriptive name. People can have different opinions about this of course, but the main approach amongst experienced programmers is to avoid them.
Here is a pointer: http://agile.dzone.com/news/flag-argument?utm_source=feedburner&utm_medium=feed&utm_campaign=Feed%3A+zones%2Fagile+%28Agile+Zone%29
Code duplication surely is a bad thing but you dont need to have duplicated code as long as you break out commons in the resulting two functions. A lot of functions is seldom a problem. The real problem is large incomprehensible functions.
Frames can be removed still supporting users without javascript since the logic happens on the server side anyway.
Users that wants to avoid javascript can avoid them using the noscript extension and enable javascript for the sites they trust. (Turning off javascript is so 1998).