#425 "Show BINARY" displaying opposite result

closed
nobody
5
2008-12-02
2008-10-30
No

"Show BINARY" displaying opposite result when Check/Optimize/Repair/Analyze tables.

I think this should fix it.

libraries/display_tbl.lib.php - line 1329
< if ($_SESSION['userconf']['display_binary'] || (isset($GLOBALS['is_analyse']) && $GLOBALS['is_analyse'])) {
---
> if (!$_SESSION['userconf']['display_binary'] || (isset($GLOBALS['is_analyse']) && $GLOBALS['is_analyse'])) {

Discussion

  • Anonymous - 2008-10-30

    Sorry, I've realized that this may be the expected result of the "Show BINARY" option.
    Though the results were to show the real BINARY contents by default on pre-3.0 releases. Not sure why it would've changed.
    Please verify. Thanks.

     
  • Marc Delisle

    Marc Delisle - 2008-10-30

    Yes, this was the default but it also displayed incorrectly true binary fields.

     
  • Marc Delisle

    Marc Delisle - 2008-11-02
    • status: open --> pending
     
  • Marc Delisle

    Marc Delisle - 2008-11-02

    Please show me a screenshot of what you mean by "opposite result".

     
  • Anonymous - 2008-11-03

    Screenshot 1

     
  • Anonymous - 2008-11-03

    Screenshot 2

     
  • Anonymous - 2008-11-03

    Screenshot 1 (screenshot_1.png): displayed after optimizing a set of tables. This displays a list of [BINARY - 14B] -like data in the table. "Show BINARY" is unchecked.

    Screenshot 2 (screenshot_2.png): after checking "Show BINARY" in the options and clicking on "Go", the actual (human-readable) message is shown. (This was what was shown by default on pre-3.0 releases, but now it's not.)

    I think the confusion here is, what does "Show BINARY" mean? I thought it would mean to show the "[BINARY - 14B]" size data when it is checked, but instead it's showing the opposite, the human-readable data.

    Is this intended, or incorrect?

     
  • Marc Delisle

    Marc Delisle - 2008-11-04
    • status: pending --> open
     
  • Marc Delisle

    Marc Delisle - 2008-11-04

    You interpreted as being Show "BINARY" instead of Show BINARY. I agree that it could be clearer, any suggestion?

    The meaning is "Show the contents of a BINARY column".

     
  • Marc Delisle

    Marc Delisle - 2008-11-16

    Any feedback?

     
  • Anonymous - 2008-11-16

    Sorry for my absence.
    How about "Show BINARY Content"?

    I was wondering if there was a reason why showing the BINARY content is not the default like in the pre-3.0 versions? Showing [BINARY - 14B] by default doesn't have any meaning to most people.
    I've noticed that if you optimize some tables, and then check "Show BINARY" from the options (with the intent to view the results as binary content) and submit, I think it'll re-optimize the table(s) again and display that all tables are already optimized (which it wasn't on the first run), thus not really showing the results of the first optimization run. Did that make sense?

     
  • Marc Delisle

    Marc Delisle - 2008-11-17

    Checkbox now selected by default.

     
  • Marc Delisle

    Marc Delisle - 2008-11-17
    • status: open --> pending
     
  • SourceForge Robot

    • status: pending --> closed
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks