#423 (ok 3.0.1) Temporary uploaded file not deleted

[David Misc]

phpMyAdmin 3.0.0
php 5.2.6
MySQL 5.0.67
Windows 2003 server
IIS 6

open_basedir is defined in php.ini

When trying to import a .sql file, it gets uploaded from my local drive and then the temporary file on the server is moved into the ./tmp folder inside the phpMyAdmin folder. The data is imported correctly.

The problem is that the temporary file inside the ./tmp folder does not get deleted after the import, even though there are sufficent permissions to delete it.

Near the bottom of import.php is the following code which deletes the temporary file that was created for the import.

// Cleanup temporary file
if ($file_to_unlink != '') {
unlink($file_to_unlink);
}

By inserting
fclose($file_to_unlink);

prior to the
unlink($file_to_unlink);

the temporary file in the phpMyAdmin/tmp folder will get deleted after the import.

[Marc Delisle]

Moved to patches.

[Marc Delisle]

Merged in subversion, thanks.

[David Misc]

When I was submitting the fix I typed the wrong variable name in the fclose() line....it should have been $import_handle. Here are the correct lines copied straight from my working import.php file:

if (!$error && $import_handle !== FALSE) {
fclose($import_handle);
}

// Cleanup temporary file
if ($file_to_unlink != '') {
unlink($file_to_unlink);
}

[Marc Delisle]

You're right and I had not tested before committing; just merged your latest fix, thanks.