Menu
▾
▴
#406 (ok 2.11.8) Table List Pagination
Patch for table list pagination in the left navigation window:
http://sourceforge.net/tracker/index.php?func=detail&aid=1772222&group_id=23067&atid=377411
navigation.php pagination patch
Logged In: YES
user_id=210714
Originator: NO
I sent you a private email about a bug encountered with this patch.
navigation.php pagination patch v2
Logged In: YES
user_id=1399574
Originator: YES
New version that correctly handles the database drop-down in the left navigation window (navigation.php_2.patch).
File Added: navigation.php_2.patch
Logged In: YES
user_id=210714
Originator: NO
Merged in subversion, thanks.
Logged In: YES
user_id=1383652
Originator: NO
nice work!
now the msg, "( 0 .. 12 / 26 )" is not needed any longer, it is even mileading now.
Also I'd suggest to change "Page number:" to
"DB page:" resp. "Table page:"
just my 2 cent
Logged In: YES
user_id=1383652
Originator: NO
correction/addition:
now the msg, "( 0 .. 12 / 26 )" is not needed any longer
it is even misleading now
IN TRUNK.
=========
in QA/2.11.8-dev it shows the correct table numbers.
Logged In: YES
user_id=210714
Originator: NO
I was not sure about displaying the hint (0 .. 12 / 26). OK I removed it.
About the messages, I agree to improve but unfortunately, for 2.11.x we are in bugfix mode so by tradition we don't add new messages.
I am not happy about having the same message "Page number:" either, so I suggest for 2.11.8 to leave "Page number" for databases and to display "Page number: (Table) for the tables. This way I can reuse previous messages.
The first one for databases is relatively near the db selector so maybe we can let it like this.
For 3.0 we have more liberty with the messages. I'm open to suggestions :)
Logged In: YES
user_id=1383652
Originator: NO
ah, ok @2.11 ..
but for 3.0 "DB/Table - page" would be more user-friendly, wouldn't it?
Logged In: YES
user_id=210714
Originator: NO
I'm looking for something clearer. You see, what is a "Table page"? We mean a page for a list of tables but I'm not sure that "Table page" means this.
Logged In: YES
user_id=1383652
Originator: NO
Agreed,
must sound funny in the ears of native english speakers ;)
Maybe a <hr> ( or somthing like {border-top:.1em solid blue}) above the table pager would be enough to make the context of "Page number" clearer.
Logged In: YES
user_id=210714
Originator: NO
... I'm not a native English speaker but it sounds funny indeed.
Good idea about the separating line.
Also, I'm thinking about replacing "Page number" by just "Page" because it's evident that what follows is a number.