#266 (in 2.6.5) server_status: rewritten

[Sebastian Mendel]

- removed list
- made html more semantic
- added description to some vars
- grouped the vars
- added link to update
- added link to reset (FLASH STATUS)
- added link to mysql manual section about SHOW STATUS
- added link FLUSH TABLES
- added link (show open tables) (not finished)
- added colors to performance related statistics
(green, red)
- removed styling from html-tags
- reduced output size by ~50% even with more content!

[Sebastian Mendel]

Logged In: YES
user_id=326580

- added more descriptions
- added a new tab to server links 'SQL'
- added server_sql.php
- changed read_dump.php and sql.php for use with server_sql.php

[Sebastian Mendel]

Logged In: YES
user_id=326580

comments are welcome!

[Sebastian Mendel]

Logged In: YES
user_id=326580

should new string in the lang prepended with something like

$strShowStatus[varname]Descr

or

$strStatus[varname]Descr

and is it acceptable to use underscores?

$strShowStatusQcache_hitsDescr

[Sebastian Mendel]

Logged In: YES
user_id=326580

v3

added GLOBAL for MySQL version greater/equal than 5.0.3

[Michal Čihař]

Logged In: YES
user_id=192186

Please separate different stuff you change. Make one patch
for server_status chages (what I like) and separate the rest
(eg. server_sql, which is anyway missing).

Also you can use lang/added_messages.php for new messages
while creating such patch, it is easier to maintain when
somebody modifies translations meanwhile.

[Sebastian Mendel]

Logged In: YES
user_id=326580

what 'lang/added_messages.php'? should i create it and
upload here?

[Michal Čihař]

Logged In: YES
user_id=192186

Just add your messages there instead of patching language
file. That file is automatically included when exists and
then messages are defined in all languages.

[Sebastian Mendel]

Logged In: YES
user_id=326580

yes i understand, but where 'there'? in my public cvs
checkout is no file 'lang/added_messages.php', so should i
create it and upload it with the patch?

[Michal Čihař]

Logged In: YES
user_id=192186

Yes there is no such file in cvs. Just create it and add
your messages into it. When commiting to cvs, all messages
will be added into all language files.

[Sebastian Mendel]

udiff against public cvs 2005-09-19

[Sebastian Mendel]

lang\added_messages.php

[Sebastian Mendel]

Logged In: YES
user_id=326580

requires

patch #1291073 PMA_formatNumber()
patch #1286451 Core Functions: added
PMA_DBI_fetch_value/single_row/result

[Michal Čihař]

Logged In: YES
user_id=192186

Did you intentionally drop parsing variable names (in old
version "Com_admin_commands" became "admin commands")? I
think original version was easier to read.

[Sebastian Mendel]

Logged In: YES
user_id=326580

yes i did, intentionally

i think its less confusing if someone searchs a specific
variable, and dont knows that phpMyAdmin renames this ... ,
also the MySQL manuall refers to 'Com_admin_commands' and
not to 'admin
commands'

[Michal Čihař]

Logged In: YES
user_id=192186

We transform data to display it in user friendly way. You
also decided to transform server traffic information, so why
not the rest?

Another thing that I just noticed:

strReset is currently used as reset button in forms, what is
in some languages translated differently than I'd call this
reset, please add new string (something like "Reset status
variables")