#249 (in 2.6.5) server_privilegs.php: how about fieldsets?

closed-accepted
Interface (183)
1
2005-12-04
2005-08-04
No

so phpMyAdmin uses XHTML und CSS2, it should also rely
on its standards and use right semantics for the
XHTML-source, so give fieldsets a try!

comments are welcome!!!

* removed width="20" from spacing cells for iconic
view, now the text is always intended by the width of
the icon

* splitted source for iconic and non-iconic view (less
if())

* added fieldsets to non-iconic view

* added class tblFooters where necessary

Discussion

  • Marc Delisle

    Marc Delisle - 2005-08-05
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2005-08-05

    Logged In: YES
    user_id=210714

    It's true that fieldsets improve the layout, so why not use
    them also for iconic view?

    This way, maybe we could avoid duplicating the code, I would
    prefer some tests on $cfg['PropertiesIconic'] instead of
    having the whole code twice.

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    ok, here is a version with fieldsets all over ...

     
  • Sebastian Mendel

    • milestone: --> 284144
     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    oh, i forgot to add the styles to this patch, sorry, i will
    add them when i am back home today - stay tuned!

     
  • Marc Delisle

    Marc Delisle - 2005-08-10

    Logged In: YES
    user_id=210714

    . . .

     
  • Marc Delisle

    Marc Delisle - 2005-08-12

    Logged In: YES
    user_id=210714

    Any news about this one?

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    no, but its not forgotten, check back in a hour or two ... i
    will add the missing styles when i am back at home ...

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    now with styles ...

     
  • Sebastian Mendel

    • milestone: 284144 --> For_immediate_release
     
  • Marc Delisle

    Marc Delisle - 2005-08-13

    Logged In: YES
    user_id=210714

    Thanks, I will check it tomorrow.

    A suggestion: maybe much (if not all) of what you added in
    both theme_right.css.php files should go instead to
    css/phpmyadmin.css.php? The goal is to:
    - avoid code duplication
    - continue supporting the other custom themes available on
    phpmyadmin.net in the download area

    What do you think of this?

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    i saw alredy that there is also css-code in
    css/phpmyadmin.css.php ... is this long time solution?... or
    are template designer advised to include this styles also in
    there templates?

    template are for 'redesign' the whole app, why should some
    style appllied 'out of control' of the templates?

    i think as a short time solution this is ok,

     
  • Marc Delisle

    Marc Delisle - 2005-08-13

    Logged In: YES
    user_id=210714

    Interesting point. We have to think about what is
    practical/important to be allowed as a change in the
    template itself, and what is not.

    Would you consider that what you added in
    theme_right.css.php should stay in a template, or should be
    common to all templates?

    Another thing to consider: I'm not a CSS expert, but I guess
    a template designer can modify in a specify template a part
    that is common (in phpmyadmin.css.php) ? Of course, we have
    to consider that the poor template designer could be
    confused by not seeing some options in theme_*.css.php,
    since they are hidden in phpmyadmin.css.php.

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    --"Would you consider that what you added in
    theme_right.css.php should stay in a template, or should be
    common to all templates?"

    i think that the templates should have the freedom to do
    whatever they want, the user has the choice if the
    template-designer did a good job or not

    phpMyAdmin only delivers the content! the templates controls
    how it is displayed - split content and design

    its like "xml and xslt" or "css and css-reader"

    -- "Another thing to consider: I'm not a CSS expert, but I guess
    a template designer can modify in a specify template a part
    that is common (in phpmyadmin.css.php) ?"

    if we add styles 'globally' in phpmyadmin.css.php than of
    course it should be apllied _before_ the styles of the
    templates, so the template-designer could overrride these
    'defaults'

    every style added to phpmyadmin.css.php should have an
    expiration date (about 6 month?) to give the
    template-designer the time to add it

    or templates should provide a version number

    in template:
    $template_ver = 2.13;

    phpmyadmin.css.php:
    include(template);
    if ( $major_version < 1 ) {
    } else {
    if ( $minor_version < 12 ) {
    ...
    }
    if ( $minor_version < 13 ) {
    ...
    }
    }

    the point is: at best there should be absolutely no style
    information before the template is loaded

    btw. the other templates could be applied as
    <LINK href="templates.css" title="dark orangblue"
    rel="alternate stylesheet" type="text/css">

    -- "Of course, we have
    to consider that the poor template designer could be
    confused by not seeing some options in theme_*.css.php,
    since they are hidden in phpmyadmin.css.php."

    thats the point, why it should added in the template
    (original) and not (only) to phpmyadmin.css.php

     
  • Marc Delisle

    Marc Delisle - 2005-08-14

    Logged In: YES
    user_id=210714

    In themes/*/info.inc.php we already have a theme generation
    and theme version number. See FAQ 2.7.

    Ok, so for now I accept the modifications to
    theme_right.css.php as you did them. But I guess that we
    have to move to $theme_version 3, both in
    themes/*/info.inc.php and in libraries/defines.lib.php.
    And custom themes will have to be upgraded before releasing
    2.6.4.
    Do you agree?

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    i would also recommend to move current style-definitions in
    phpmyadmin.css.php before the include of the template sytel
    definitions - so the templates can override this!

    or even better when increasing template version, we should
    move all styles out of phpmyadmin.css.php into the themes,
    also i would suggest with this next version to also include
    'theme_both.css.php' - so some style-definitions needn't
    defined twice in right and left

    and at least create a new file 'css/newstyles.css.php' where
    we can collect newly added styles between template version
    upgrades - dont add any styles in 'phpmyadmin.css.php'

    this makes all a little bit clearer

    css/phpmyadmin.css.php
    - includes them based styles
    css/newstyles.css.php
    - is included by phpmyadmin.css.php before theme-styles
    - holds new style definitions
    - is cleared with every new template-version

     
  • Marc Delisle

    Marc Delisle - 2005-08-14

    Logged In: YES
    user_id=210714

    Sebastian,
    these happen when editing a db-specific privilege, do you
    want to fix it?

    Notice: Undefined index: max_questions in
    server_privileges.php on line 418

    Notice: Undefined index: max_updates in
    server_privileges.php on line 422

    Notice: Undefined index: max_connections in
    server_privileges.php on line 426
    -----------
    I agree with your 2 first paragraphs, but I don't know if we
    will have the time to do it for 2.6.4.

    About newstyles.css.php, I don't think it's necessary,
    because we want to avoid confusion about where to modify the
    styles. CVS tells us the changes and usually it's someone
    from the team who upgrades custom themes to the latest version.

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    -- "Notice: Undefined index: max_questions in
    server_privileges.php on line 418"

    is this error raised by my patch? i dont think so, or? comes
    this from a specific mysql version or missed/wrong privileg
    tables?

     
  • Marc Delisle

    Marc Delisle - 2005-08-16

    Logged In: YES
    user_id=210714

    This does not happen with current HEAD, but happens
    everytime I edit a database-specific privileges after
    applying the patch.

    Tested on MySQL 4.1.13 and 5.0.11.

     
  • Marc Delisle

    Marc Delisle - 2005-08-28
    • priority: 5 --> 1
    • summary: server_privilegs.php: how about fieldsets? --> (in 2.6.5) server_privilegs.php: how about fieldsets?
    • status: open --> open-accepted
     
  • Marc Delisle

    Marc Delisle - 2005-08-28

    Logged In: YES
    user_id=210714

    Bug fixed: I enclosed some code with
    if ($db == '*') {
    }

    Patch merged.

     
  • Sebastian Mendel

    Logged In: YES
    user_id=326580

    oh, sorry for not fixing that, i was in holidays last two
    weeks ... and thanks for accepting all the other patches
    provided

     
  • Marc Delisle

    Marc Delisle - 2005-12-04
    • status: open-accepted --> closed-accepted
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks