#184 fix last published and future injection problems

closed-rejected
Privileges (8)
1
2004-02-04
2004-02-03
Anonymous
No

Rene Luria <operator@infomaniak.ch>
(in production on 2.5.5-pl1 since 9jan2004 and used by over 15'000
clients)

--- libraries/common.lib.php Wed Feb 4 00:21:16 2004
+++ libraries/common.lib.php.new Wed Feb 4 00:31:31 2004
@@ -1882,6 +1882,8 @@
if (!isset($GLOBALS[$param])) {
$error_message .= $reported_script_name . ': Missing
' . $param . '<br />';
$found_error = TRUE;
+ } else {
+ $GLOBALS[$param] =
preg_replace('@\.\.*@','.',$GLOBALS[$param]);
}
}
if ($found_error) {

Discussion

  • Olivier Mueller

    Olivier Mueller - 2004-02-04

    Logged In: YES
    user_id=15563

    PS: submitted by SF user 'herel'

     
  • Garvin Hicking

    Garvin Hicking - 2004-02-04
    • status: open --> closed
     
  • Garvin Hicking

    Garvin Hicking - 2004-02-04

    Logged In: YES
    user_id=473563

    If that code is in productive use, you should remove it
    immediately. It does serious harm to your user's input queries.

    Think of what happens to this query:

    SELECT id, directory FROM directories WHERE parent = '..';

    For every query you use, or also other inputs, your input
    will be translated to a single dot.

    Because of that, we can't include this patch in our
    distribution.

    However, thanks for trying to improve phpMyAdmin!

    Best regards,
    Garvin.

     
  • Garvin Hicking

    Garvin Hicking - 2004-02-04
    • priority: 5 --> 1
    • assigned_to: nobody --> garvinhicking
    • status: closed --> closed-rejected
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks