#665 (in 2.6.2) Rename tbl_row_delete.php to tbl_row_action.php

Needs_decision
fixed
1
2013-06-11
2005-01-07
jamaz
No

version: PHPMyAdmin/phpMyAdmin-2.6.0-pl2

When exporting selected rows from page with table
records
(sql.php?lang=...&server=.&db=...&table=...s&goto=tbl_properties.php&back=tbl_properties.php&sql_query=SELECT+%2A+FROM+%60...%60&pos=0),
the target action is tbl_row_delete.php (<form
method="post" action="tbl_row_delete.php"
name="rowsDeleteForm">)

This name reflected the reality in previous versions,
where rows could be only deleted. Now multiple rows can
be deleted or updated or exported.

I was a little confused when I wished to export some
rows and the URL was tbl_row_delete.php

Rename target script from tbl_row_delete.php to
tbl_row_action.php would prevent this confusion

Discussion

  • Michal Čihař

    Michal Čihař - 2005-01-10
    • milestone: --> Needs_decision
     
  • Michal Čihař

    Michal Čihař - 2005-01-10

    Logged In: YES
    user_id=192186

    The problem is that when we rename file in cvs, we lose its
    history... I thing confusing somebody who needs to look into
    code is easier way to go ;-)

     
  • Marc Delisle

    Marc Delisle - 2005-01-10

    Logged In: YES
    user_id=210714

    Michal,
    let's improve the code and do the rename now. We just have
    to put a comment in the file referring to the old
    tbl_row_delete.php.

     
  • Michal Čihař

    Michal Čihař - 2005-01-11

    Logged In: YES
    user_id=192186

    Feel free to rename, but all tbl_properties_* and
    db_details_* could have better name...

     
  • Marc Delisle

    Marc Delisle - 2005-03-13
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2005-03-13

    Logged In: YES
    user_id=210714

    Done. Yes Michal we should improve other script names as well.

     
  • Marc Delisle

    Marc Delisle - 2005-03-13
    • priority: 5 --> 1
    • summary: Rename script from tbl_row_delete.php to tbl_row_action.php --> (in 2.6.2) Rename tbl_row_delete.php to tbl_row_action.php
    • status: open --> open-fixed
     
  • Marc Delisle

    Marc Delisle - 2005-04-22
    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed