Menu
▾
▴
#1609 (ok 4.5) Additional page locking
When making changes to a page, we lock the page so that the user is prompted before navigating away and losing pages. This feature is established and works as expected.
There are several pages where the lock behavior does not occur and I feel it should:
- Structure tab (both Table structure and Relation view)
- SQL tab
- Search tab
- Query tab
I am able to reproduce it for all the above except for SQL tab. While I try to navigate away having written a query in query-box, it prompts me of unsaved changes and whether or not to leave the page.
Can I try implementing it?
Interesting, I'm working with master and have just tried again and still do not get any prompt before navigating away from the SQL tab. This may require further investigation.
Anyway, yes, you're welcome to work on this as it's not assigned to anyone (the "Owner" field).
Well,
I solved it for the sql tab,search tab and the query tab. Apparently, I just had to add a class "lock-page" in the form elements in the page.
I wanted to ask that the current functionality of lock-page mechanism works only if we edit any text-area or text input element in the form . What about other fields in the form, like selection list and check-boxes? It may happen that the user might have just checked an unchecked box , without editing the text area.So should I also implement the changes for them too?
This would be a good idea.
I have solved the issue for all the tabs listed above. But the current functionality works only if we are editing textareas or text-input boxes.
I think we should extend this for check-boxes, radio-buttons and other page elements also. What do you think?
Sorry for the delay in implementing this, as I had other commitments.
I have implemented the above feature for all page elements of all the above mentioned pages. In which branch should I push my commits?
As 4.4 is feature-frozen, use the master branch.
I tried to push my changes to master branch, but my local branch is not
getting merged successfully with local master branch. I will try fix it.
Meanwhile, I have pushed the commit to QA_4_3 for safety and created a pull
request.
Is it ok?
On Wed, Mar 11, 2015 at 11:52 PM, Marc Delisle lem9@users.sf.net wrote:
Related
Feature Requests: #1609
So that means that i should remove this feature from database pages and
implement it to all the before-mentioned pages for table structure?
Please check out my pull request in which i have made changes only for
database ,and see if you want to keep them or not.
For tables ,it is easy and will solve it today.
On Mar 12, 2015 4:01 AM, "tapanhalani" tapanhalani@users.sf.net wrote:
Related
Feature Requests: #1609
Marc,
Was the above feature for table structure or for database ? Because I
implemented it for database, not for table. While after reading the
statement again, this doubt arised .
However, it won't take much time to implement it to tables strucuture, as I
have already implemented it for database.
On Thu, Mar 12, 2015 at 2:56 AM, Tapan Halani tapanhalani231@gmail.com
wrote:
Related
Feature Requests: #1609
Hi Marc,
I have successfully implemented the above feature for all the above tabs in table structure and also the query tab of database view. Is there anything else that I am missing regarding this feature?
Now the page will lock navigation upon changing any element of the page.
Hi Tapan,
locking dropdowns is still under discussion.
I wiuld remove it from the code.. Anything else?
pull request:- https://github.com/phpmyadmin/phpmyadmin/pull/1572
As you said, it is in master branch.