Menu

#1594 (ok 4.5) More plain English configuration options for icon link destinations

Needs_decision
resolved
GSoC 2015 (10)
Normal
2015-06-12
2015-01-13
No

I believe this was initially proposed by Marc.

Regarding $cfg['NavigationTreeDefaultTabTable']:

Currently, there are 5 possible values for this configuration variable:

  • 'tbl_structure.php' = fields list
  • 'tbl_sql.php' = SQL form
  • 'tbl_select.php' = search page
  • 'tbl_change.php' = insert row page
  • 'sql.php' = browse page
    By the way, using script names as values for such variables has always bothered me. I would prefer more neutral strings like 'search', 'structure' and so on.

We should probably do the same with:

$cfg['DefaultTabServer'] = 'index.php';

  • 'index.php' = the welcome page
  • 'server_databases.php' = list of databases
  • 'server_status.php' = runtime information
  • 'server_variables.php' = MySQL server variables
  • 'server_privileges.php' = user management

$cfg['DefaultTabDatabase'] = 'db_structure.php';

  • 'db_structure.php' = tables list
  • 'db_sql.php' = SQL form
  • 'db_search.php' = search query
  • 'db_operations.php' = operations on database

$cfg['DefaultTabTable'] = 'sql.php';

  • 'tbl_structure.php' = fields list
  • 'tbl_sql.php' = SQL form
  • 'tbl_select.php' = search page
  • 'tbl_change.php' = insert row page
  • 'sql.php' = browse page

Discussion

  • Marc Delisle

    Marc Delisle - 2015-02-15
    • Priority: 5 --> Normal
     
  • Isaac Bennetch

    Isaac Bennetch - 2015-04-08
    • labels: --> GSoC 2015
     
  • Deven Bansod

    Deven Bansod - 2015-06-09

    Hi,

    Does this mean to change the 'value of the options itself' or does this mean to make it only better presentable to the user (with neutral strings like 'browse', 'structure' etc. only in the 'select input' on pref_forms while underlying values of the options remain same like sql.php etc.) ?

     
    • Isaac Bennetch

      Isaac Bennetch - 2015-06-09

      Changing the values of the configuration options themselves; however your logic for processing the new values should also deal appropriately with the old filename-based options, too.

      The new configuration directive would be, for instance, $cfg['NavigationTreeDefaultTabTable'] = 'browse';

      Does that help?

       
  • Deven Bansod

    Deven Bansod - 2015-06-09

    Yes. Thanks a lot. Have started working on it.


    Will make a PR soon.

     
  • Isaac Bennetch

    Isaac Bennetch - 2015-06-12
    • summary: More plain English configuration options for icon link destinations --> (ok 4.5) More plain English configuration options for icon link destinations
    • status: open --> resolved