Menu

#1589 (ok 4.0.10.8) support early versions of PHP5.2 (register_shutdown_function)

Next_minor_version
fixed
None
1
2015-01-07
2015-01-05
No

Fix for 4.0 branch.

in PHP callbacks, 'class::function' support was added in 5.2.3. Prior to this version, array('class', 'function') was required. Due to 4.0's attempt to support 5.2, this harmless change could be made to libraries/OutputBuffering.class.php, function start().

Rather than:

        register_shutdown_function('PMA_OutputBuffering::stop');

instead:

        register_shutdown_function(array('PMA_OutputBuffering','stop'));

Discussion

  • sudshekhar

    sudshekhar - 2015-01-06

    Hey,

    Can I work on this change?

     
  • Isaac Bennetch

    Isaac Bennetch - 2015-01-06

    This seems like a reasonable change and no one is assigned, so yes you can work on it.

     
  • Marc Delisle

    Marc Delisle - 2015-01-06
    • assigned_to: Marc Delisle
     
  • Marc Delisle

    Marc Delisle - 2015-01-06

    Thanks Ian. Are you the author of this patch? Do you agree with our DCO? (see https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO)

     
  • Ian P. Christian

    I am and I do!

    Thanks for your help Marc.

     
  • Marc Delisle

    Marc Delisle - 2015-01-07
    • summary: change to resister_shutdown_fuction to support early versions of PHP5.2 --> support early versions of PHP5.2 (register_shutdown_function)
     
  • Marc Delisle

    Marc Delisle - 2015-01-07
    • summary: support early versions of PHP5.2 (register_shutdown_function) --> (ok 4.0.10.8) support early versions of PHP5.2 (register_shutdown_function)
    • status: open --> resolved
    • Priority: 9 --> 1
     
  • Marc Delisle

    Marc Delisle - 2015-01-07
    • status: resolved --> fixed