Menu

#1568 (ok 4.4) Add Column After / Before

Next_release
fixed
None
Low
2015-04-20
2014-12-06
No

The Add Column After radio buttons in tbl_structure.php can be folded into the dropdown if you add a BEGIN and/or END entry to the dropdown.

IMO an END entry and adding the column BEFORE it would be simpler, but the choice is somewhat arbitrary. I think PHP and C++ use BEFORE and END in such code.

Discussion

  • Smita Kumari

    Smita Kumari - 2015-01-08
    • assigned_to: Smita Kumari
     
  • Madhura Jayaratne

    Hi Smita,
    I had a look at this rfe today. But I thought it is easier to make the choice with the current interface and did not go ahead with the proposed changes. I feel it's best to ask on the dev mailing list about the change.

     
    • Marc Delisle

      Marc Delisle - 2015-01-08

      Hi Madhura,
      my feeling is that this dialog would benefit from an improvement, especially if the selector is positionned by default to add at the end of the table.

       
      • Madhura Jayaratne

        @Marc
        Yes, it will probably improve the usability in the configuration you described.

         
  • Smita Kumari

    Smita Kumari - 2015-01-11

    Hey, sorry I had to go out of town so couldn't follow.
    So as I am understanding, we can have just one drop down with: optgroup "At", options BEGIN & END and optgroup "After", options all the columns name.
    Will that look good ?

     
  • Olaf van der Spek

    I'd not use optgroups. If you decide to go with after instead of before, just add BEGIN and not END.

     
  • Smita Kumari

    Smita Kumari - 2015-01-13

    Here is the PR: https://github.com/phpmyadmin/phpmyadmin/pull/1459

    @Olaf: Yeah, I went with After and Begin as Mysql uses After and First in their queries not 'Before' so will have some consistency.

     
  • Marc Delisle

    Marc Delisle - 2015-01-14
    • summary: Add Column After / Before --> (ok 4.4) Add Column After / Before
    • status: open --> resolved
    • Group: Needs_decision --> Next_release
    • Priority: 5 --> 1
     
  • Marc Delisle

    Marc Delisle - 2015-02-15
    • Priority: 1 --> Normal
     
  • Marc Delisle

    Marc Delisle - 2015-02-15
    • Priority: Normal --> Low
     
  • Marc Delisle

    Marc Delisle - 2015-04-20
    • Status: resolved --> fixed
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.