Menu

#1551 (ok 4.5) Integrate SQL debugging into console

Next_release
resolved
GSoC 2015 (10)
Low
2015-06-19
2014-10-20
No

Target: version 4.5

SQL debugging is a feature that helps developers debug SQL queries generated by phpMyAdmin and is enabled by $cfg['DBG']['sql'] configuration. As suggested by Marc Delisle, it would be better to integrate SQL debugging to the new console (to be) introduced in version 4.3

Related

Feature Requests: #1551

Discussion

  • Marc Delisle

    Marc Delisle - 2014-11-16
    • assigned_to: Marc Delisle
     
  • Marc Delisle

    Marc Delisle - 2015-02-06
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,3 @@
    +Target: version 4.5
    +
     SQL debugging is a feature that helps developers debug SQL queries generated by phpMyAdmin and is enabled by $cfg['DBG']['sql'] configuration. As suggested by Marc Delisle, it would be better to integrate SQL debugging to the new console (to be) introduced in version 4.3
    
     
  • Marc Delisle

    Marc Delisle - 2015-02-15
    • Priority: 5 --> Normal
     
  • tapanhalani

    tapanhalani - 2015-03-18

    So basically this feature wants to include the information shown at the bottom of the page when $cfg['DBG']['sql'] = true , as a part of sql debugging process (like query executed, number of times it is executed, time taken etc.) to be included dynamically in the newer console in PMA window?

    Am I right?

     
  • Madhura Jayaratne

    Correct.
    Probably in another tab to distinguish them from user issued queries.

     
  • tapanhalani

    tapanhalani - 2015-03-19

    There is one doubt.

    In DatabaseInerface.class.php , the function _dbgQuery() is defined as private . Since this is the place where debugging information is generated for all the queries, how would I be able to use it in console class to generate debug information there?

     
    • Marc Delisle

      Marc Delisle - 2015-03-19

      I believe it's premature to discuss the implementation right now, as this would be part of the GSoC proposal(s).

       
      • tapanhalani

        tapanhalani - 2015-03-19

        Ok. I will include my implementation ideas in my proposal.
        On Mar 19, 2015 6:28 PM, "Marc Delisle" lem9@users.sf.net wrote:

        I believe it's premature to discuss the implementation right now, as this
        would be part of the GSoC proposal(s).


        Status: open
        Group: Needs_decision
        Created: Mon Oct 20, 2014 04:25 AM UTC by Madhura Jayaratne
        Last Updated: Thu Mar 19, 2015 10:17 AM UTC
        Owner: Marc Delisle

        Target: version 4.5

        SQL debugging is a feature that helps developers debug SQL queries
        generated by phpMyAdmin and is enabled by $cfg['DBG']['sql']
        configuration. As suggested by Marc Delisle, it would be better to
        integrate SQL debugging to the new console (to be) introduced in version 4.3


        Sent from sourceforge.net because you indicated interest in
        https://sourceforge.net/p/phpmyadmin/feature-requests/1551/

        To unsubscribe from further messages, please visit
        https://sourceforge.net/auth/subscriptions/

         

        Related

        Feature Requests: #1551

  • Marc Delisle

    Marc Delisle - 2015-03-19
    • labels: --> GSoC 2015
     
  • Nisarg Jhaveri

    Nisarg Jhaveri - 2015-06-13

    What does it actually mean by integrating SQL debugging in console? Show debug info in console somehow, as Madhura pointed, in new tab or something?

     
    • Marc Delisle

      Marc Delisle - 2015-06-13

      Nisarg,
      I assume that you are familiar with the current way SQL debugging is displayed: it's just appended at the bottom of page. Also, it's difficult to interpret. Yes, it could be integrated in a new tab of the console, but I expect some creativity on your part to also improve the way it's displayed. As an example, I don't always want to see the trace for each query, so there should be various levels of display details.

       
    • Madhura Jayaratne

      Maybe,
      1. Ability to see individual queries or group them when there are multiple executions of the same SQL
      2. Ability the show/hide trace
      3. Ability to sort by execution order, execution time, no. of calls etc.
      4. A quick search.

       
      • Marc Delisle

        Marc Delisle - 2015-06-14

        Madhura,
        this is fine but I am wondering: we are still talking about all the queries generated by one action, right? Currently the SQL debugger is limited to that and I am fine with this. We don't plan to store this debugging info permanently, right?

         
        • Madhura Jayaratne

          Yes, for queries generated by one action. I don't think we need to over complicate this feature request.

           
      • Nisarg Jhaveri

        Nisarg Jhaveri - 2015-06-15

        I'm not sure about the usefulness of search. On an average, there is about 15 queries. Searching in these 15-20 queries doesn't make much sense to me. Thoughts?

         
        • Marc Delisle

          Marc Delisle - 2015-06-15

          I share Nisarg's opinion on this.

           
  • Nisarg Jhaveri

    Nisarg Jhaveri - 2015-06-19

    Any suggestions for sorting UI? How/Where to show buttons(or something else) for sorting queries?

     
  • Madhura Jayaratne

    What I initially had in mind was a sortable table. Something like the network tab of Chrome console. I don't know whether that is feasible though.

     
  • Nisarg Jhaveri

    Nisarg Jhaveri - 2015-06-19

    It doesn't fit in how the console debugging is right now. Anyway, I've implemented something in https://github.com/phpmyadmin/phpmyadmin/pull/1746. I am not so happy about it, but looks like the best option. Suggestions?

     
  • Marc Delisle

    Marc Delisle - 2015-06-19
    • summary: Integrate SQL debugging into console --> (ok 4.5) Integrate SQL debugging into console
    • status: open --> resolved
    • Group: Needs_decision --> Next_release
    • Priority: Normal --> Low