#1518 (ok 4.3) Confirm dialog on accidentally leaving a page

Needs_decision
fixed
None
1
2014-12-05
2014-04-17
Minhaz
No

I think there should be a confirm navigation confirmation if user makes an attempt to leave corresponding page, while he has already started another operation like creating table.

Have a look at attachment for further details

1 Attachments

Discussion

  • Marc Delisle

    Marc Delisle - 2014-04-19
    • assigned_to: Marc Delisle
     
  • Marc Delisle

    Marc Delisle - 2014-04-19
    • summary: Confirm Navigation dialog on accidentally leaving a page --> Confirm dialog on accidentally leaving a page
     
  • Marc Delisle

    Marc Delisle - 2014-04-19
    • summary: Confirm dialog on accidentally leaving a page --> (ok 4.2) Confirm dialog on accidentally leaving a page
    • status: open --> resolved
    • Group: Needs_decision --> Next_release
    • Priority: 5 --> 1
     
  • Isaac Bennetch

    Isaac Bennetch - 2014-04-22

    Hi, Sorry for joining the conversation late; I thought I posted a comment four days ago, but apparently a browser crash caused that not to happen so this might be a bit late to add...but anyway,

    This is a good idea, but we should be careful about where we implement it. Places where the user has entered a large amount of data in a time-consuming way certainly can benefit from this (SQL tab, the create fields page when creating a new table, etc). I do not think it should be used, for instance, on the Create Table dialog as shown in your screenshot. The odds a user has changed their mind and wants to navigate away are greater than the work required to re-type "tbl_users" and "3" in the form.

    Just my two cents, but we shouldn't make navigating around everywhere more difficult; only protect the user when there's a good chance they've spent some time entering data.

    Also, I do not think this requires adding a new configuration option.

     
  • Marc Delisle

    Marc Delisle - 2014-04-22
    • summary: (ok 4.2) Confirm dialog on accidentally leaving a page --> Confirm dialog on accidentally leaving a page
    • status: resolved --> open
    • assigned_to: Marc Delisle --> nobody
    • Group: Next_release --> Needs_decision
    • Priority: 1 --> 5
     
  • Minhaz

    Minhaz - 2014-04-22

    I have corrected the patch, in fact written a different one.
    This one will trigger only when the values of the input fields in form are not the one they were loaded with. rest you can understand from the code at: https://github.com/phpmyadmin/phpmyadmin/pull/1152

     
  • Chirayu Chiripal

    Hi, IMO, first we need to decide how much of unsaved data (i.e. minimum no. of fields with unsaved/modified value or based on no. of characters) should trigger this dialog on leaving page.

     
  • Michal Čihař

    Michal Čihař - 2014-05-10

    Merged to master.

     
  • Michal Čihař

    Michal Čihař - 2014-05-10
    • summary: Confirm dialog on accidentally leaving a page --> (ok 4.3) Confirm dialog on accidentally leaving a page
    • status: open --> resolved
    • assigned_to: Michal Čihař
    • Priority: 5 --> 1
     
  • Marc Delisle

    Marc Delisle - 2014-12-05
    • Status: resolved --> fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks