I have found a very ugly icon in phpMyAdmin. It is possible to change it? It looks like Windows 95. I have made a screenshot and a new example for it.
Maybe you can change it.
Thank you :)
I'm completely new to open source and ticketing. I'm willing to change this icon - how do I go about it? Do I submit a screenshot here? It is my first time ever post here - I'm going to read more about how to contribute but when I saw this request I thought it would be somewhere where I could start.
yes you can submit a screenshot.
Thank you Marc :)
Hi Marc. I have submitted today a commit to the github repository. I generated new sprites.png file which includes a new icon for the pmahomme theme that replaced the old one and new sprites.lib.php file with new dimensions. Here is a link to my commit https://github.com/alicjalicja/phpmyadmin/commit/caf348bae43575f8b8f5fa0e083845fa22743f55#commitcomment-4150058
I hope I did it the right way - my first commit :)
Thanks for your suggestion. However, instead of copying an image file to
another one, there is a better way.
I propose to replace references of b_info.png to s_info.png in the code.
If you agree, I'll make a commit for that, in your name.
I agree that would be a much better solution. I thought about it but I wasn't sure how to go about it. That would be great if you can change it or even direct me on how to find the references and replace them. Thank you !
Alicja, you can begin by searching the source code for references to the two icon files (grep and git grep are good commands to use for this if you're on a *nix-like system). That will give you an idea from where the icons are referenced in the code.
Thank you Isaac, I have just tried the find tool on netbeans as I'm on windows and found a reference in 2 files. I changed the FormDisplay.tpl.php file and seems to be changing the reference. I included the screenshot. Should I commit this change?
and another file history.js here
yes please commit these changes. There is also this file:
Can you do your commit in a newly-created branch in your tree? This branch should not contain your previous commit where you were copying the image file.
do you need any help about these issues?
Thank you for your help offer.
I'm just going through some sources on github and git itself. I want to understand it better before I make the changes you mentioned. I may ask you for help once I am through a bit more materials on git and github.
Thank you very much for all your help already
I have created a new branch and initiated pull request here https://github.com/phpmyadmin/phpmyadmin/pull/721. I hope this is all that was needed. It was quite an adventure to learn git and github :). Thank you very much for all your help. I have a question, when I was writing a commit on my branch I got these errors as seen on the screenshot (I'm on windows 7) Do you know if they affect commits in any way?
Nowadays it's useful to learn git and github, I'm sure this new skill will help you. Regarding the error message, I verified your whole branch, and your commit did not change the end of lines from Unix-style (LF, which we use) to DOS-style (CRLF), so I'm not sure why the warning was displayed.
Git is a great tool - I'm still at the beginning of learning it though- so I welcome any suggestions you have for beginners.
Regarding this commit - I tested it and the original theme is looking for the s_info.png in themes/original/img/ folder. I copied a b_info.png and renamed it to s_info.png in the same folder and it fixed it. Should I commit it as a new branch as a temporary solution? I have noticed that the naming conventions for these icons are not consistent - for example the pmahomme uses ic_b_help and ic_s_info.
this is the error in the original theme which is corrected when I add s_info.png to the img folder
it would be better to copy the s_info.png from pmahomme to original, to benefit from the better icon. Please prepare a commit with this, in a new branch.
I'll handle the sprite generation afterwards, as it must be done on Linux (see http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage#Regenerating_the_sprites).
When I looked in the source code it showed that the original theme doesn't use the sprite for the Wiki icon. And if I copy the s_info.png to the original theme then it will be using newer icon which would not match the Original theme.
this is what it looks like if I copy s_info.png from pmahomme. The icons don't match
ok, let's keep the older-style icon for original.
thank you, do I then recommit my previous branch?
No need to recommit, your commit was there. I had closed the pull request but reopened and merged it.
oh I just saw it :) thank you Marc !!