#1457 (ok 4.1) Stone Age icon found

Needs_decision
fixed
None
1
2013-12-12
2013-08-31
dennis1993
No

Hey guys,

I have found a very ugly icon in phpMyAdmin. It is possible to change it? It looks like Windows 95. I have made a screenshot and a new example for it.

Maybe you can change it.

Thank you :)

1 Attachments

Discussion

1 2 > >> (Page 1 of 2)
  • Alicja
    Alicja
    2013-09-01

    Hi,

    I'm completely new to open source and ticketing. I'm willing to change this icon - how do I go about it? Do I submit a screenshot here? It is my first time ever post here - I'm going to read more about how to contribute but when I saw this request I thought it would be somewhere where I could start.

     
  • Marc Delisle
    Marc Delisle
    2013-09-02

    Alicja,
    yes you can submit a screenshot.

     
  • Alicja
    Alicja
    2013-09-03

    Thank you Marc :)

     
  • Marc Delisle
    Marc Delisle
    2013-09-22

    • assigned_to: Marc Delisle
     
  • Marc Delisle
    Marc Delisle
    2013-09-22

    Hi Alicja,

    Thanks for your suggestion. However, instead of copying an image file to
    another one, there is a better way.

    I propose to replace references of b_info.png to s_info.png in the code.

    If you agree, I'll make a commit for that, in your name.

     
  • Alicja
    Alicja
    2013-09-22

    Hi Marc,

    I agree that would be a much better solution. I thought about it but I wasn't sure how to go about it. That would be great if you can change it or even direct me on how to find the references and replace them. Thank you !

     
    Last edit: Alicja 2013-09-22
  • Isaac Bennetch
    Isaac Bennetch
    2013-09-22

    Alicja, you can begin by searching the source code for references to the two icon files (grep and git grep are good commands to use for this if you're on a *nix-like system). That will give you an idea from where the icons are referenced in the code.

     
  • Alicja
    Alicja
    2013-09-22

    Thank you Isaac, I have just tried the find tool on netbeans as I'm on windows and found a reference in 2 files. I changed the FormDisplay.tpl.php file and seems to be changing the reference. I included the screenshot. Should I commit this change?

     
    Attachments
  • Alicja
    Alicja
    2013-09-22

    and another file history.js here

     
    Attachments
  • Marc Delisle
    Marc Delisle
    2013-09-22

    Hi Alicja,
    yes please commit these changes. There is also this file:
    test/libraries/PMA_FormDisplay_tpl_test.php

    Can you do your commit in a newly-created branch in your tree? This branch should not contain your previous commit where you were copying the image file.

     
  • Marc Delisle
    Marc Delisle
    2013-09-25

    Hi Alicja,
    do you need any help about these issues?

     
  • Alicja
    Alicja
    2013-09-26

    Hi Marc,

    Thank you for your help offer.
    I'm just going through some sources on github and git itself. I want to understand it better before I make the changes you mentioned. I may ask you for help once I am through a bit more materials on git and github.

    Thank you very much for all your help already

     
  • Alicja
    Alicja
    2013-09-28

    Hi Marc,

    I have created a new branch and initiated pull request here https://github.com/phpmyadmin/phpmyadmin/pull/721. I hope this is all that was needed. It was quite an adventure to learn git and github :). Thank you very much for all your help. I have a question, when I was writing a commit on my branch I got these errors as seen on the screenshot (I'm on windows 7) Do you know if they affect commits in any way?

     
    Attachments
  • Marc Delisle
    Marc Delisle
    2013-09-28

    Hi Alicja,
    Nowadays it's useful to learn git and github, I'm sure this new skill will help you. Regarding the error message, I verified your whole branch, and your commit did not change the end of lines from Unix-style (LF, which we use) to DOS-style (CRLF), so I'm not sure why the warning was displayed.

     
  • Marc Delisle
    Marc Delisle
    2013-09-28

    • summary: Stone Age icon found --> (ok 4.1) Stone Age icon found
    • status: open --> resolved
    • Priority: 5 --> 1
     
  • Alicja
    Alicja
    2013-09-28

    Hi Marc,
    Git is a great tool - I'm still at the beginning of learning it though- so I welcome any suggestions you have for beginners.
    Regarding this commit - I tested it and the original theme is looking for the s_info.png in themes/original/img/ folder. I copied a b_info.png and renamed it to s_info.png in the same folder and it fixed it. Should I commit it as a new branch as a temporary solution? I have noticed that the naming conventions for these icons are not consistent - for example the pmahomme uses ic_b_help and ic_s_info.

     
  • Alicja
    Alicja
    2013-09-28

    this is the error in the original theme which is corrected when I add s_info.png to the img folder

     
    Attachments
  • Marc Delisle
    Marc Delisle
    2013-09-28

    Hi Alicja,
    it would be better to copy the s_info.png from pmahomme to original, to benefit from the better icon. Please prepare a commit with this, in a new branch.

    I'll handle the sprite generation afterwards, as it must be done on Linux (see http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage#Regenerating_the_sprites).

     
  • Alicja
    Alicja
    2013-09-28

    Hi Marc,
    When I looked in the source code it showed that the original theme doesn't use the sprite for the Wiki icon. And if I copy the s_info.png to the original theme then it will be using newer icon which would not match the Original theme.

     
    Attachments
  • Alicja
    Alicja
    2013-09-28

    this is what it looks like if I copy s_info.png from pmahomme. The icons don't match

     
    Attachments
  • Marc Delisle
    Marc Delisle
    2013-09-28

    Hi Alicja,
    ok, let's keep the older-style icon for original.

     
  • Alicja
    Alicja
    2013-09-28

    thank you, do I then recommit my previous branch?

     
    Last edit: Alicja 2013-09-28
    • Marc Delisle
      Marc Delisle
      2013-09-28

      No need to recommit, your commit was there. I had closed the pull request but reopened and merged it.

       
  • Alicja
    Alicja
    2013-09-28

    oh I just saw it :) thank you Marc !!

     
1 2 > >> (Page 1 of 2)