Menu

#1359 (ok 4.5) Ctrl navigation in grid editor

Needs_decision
resolved
Normal
2015-06-04
2012-03-17
No

The JS grid editor could allow navigating with Ctrl+Arrow keys, as is possible in the tbl_change.php row editor.
Would this interfere with any blur-events that autosave the field with Ajax?

Discussion

  • Isaac Bennetch

    Isaac Bennetch - 2014-11-16
    • labels: Interface Improvements --> Interface Improvements, gsoc
    • assigned_to: Isaac Bennetch
     
  • Marc Delisle

    Marc Delisle - 2015-02-15
    • Priority: 5 --> Normal
     
  • Pranav Sharma

    Pranav Sharma - 2015-03-26

    So for instance, Ctrl + Arrows keys should allow navigation in the main dashboard panel of PMA? For instance in the table structure tab? Is that the requirement?

     
  • Deven Bansod

    Deven Bansod - 2015-05-30

    Please correct me if I am wrong.

    This feature wishes to implement CTRL + Arrow Keys Navigation in JS Grid Editor (on sql.php i.e. while browsing a table).

    Now assuming the above description is correct,
    Should moving from one 'currently-editing' cell to its adjacent(above, below, right, left) cell by way of this feature, should we save the currently edited cell or we should ignore those changes ?
    Or should we provide an added option (of may be CTRL + SHIFT + Arrow) for navigating without saving (while CTRL + Arrow would by default save the previous cell data).

     
    • Isaac Bennetch

      Isaac Bennetch - 2015-06-01

      This feature wishes to implement CTRL + Arrow Keys Navigation in JS Grid Editor (on sql.php i.e. while browsing a table).

      Exactly.

      Should moving from one 'currently-editing' cell to its adjacent(above, below, right, left) cell by way of this feature, should we save the currently edited cell or we should ignore those changes ?

      We should save the changes, just like is currently done when clicking the mouse away from an edited cell.

      Or should we provide an added option (of may be CTRL + SHIFT + Arrow) for navigating without saving (while CTRL + Arrow would by default save the previous cell data).

      Good idea, but I don't think this is needed at all.

       
  • Isaac Bennetch

    Isaac Bennetch - 2015-06-04

    Using both ctrl and alt keys (for Mac users, in particular), this is implemented with https://github.com/phpmyadmin/phpmyadmin/pull/1713

     
  • Isaac Bennetch

    Isaac Bennetch - 2015-06-04
    • labels: Interface Improvements, gsoc --> Interface Improvements, GSoC 2015
    • summary: Ctrl navigation in grid editor --> (ok 4.5) Ctrl navigation in grid editor
    • status: open --> resolved