#877 (in 2.5.1) 2.5.1-rc1 frameset generation

fixed
nobody
None
1
2013-06-11
2003-05-27
No

in index.php line ~100

unclear trinary operator
-> no right frame

echo ' <frame src="' . (empty($db)) ? 'main.php3' :
$cfg['DefaultTabDatabase'] . '?' . $url_query . '"
name="phpmain' . $phpmain_hash . '" frameborder="1" />'
. "\n";

must be :

echo ' <frame src="' . ((empty($db)) ? 'main.php3' :
$cfg['DefaultTabDatabase']) . '?' . $url_query . '"
name="phpmain' . $phpmain_hash . '" frameborder="1" />'
. "\n";

or :

echo ' <frame src="';
echo (empty($db)) ? 'main.php3' :
$cfg['DefaultTabDatabase'];
echo '?' . $url_query . '" name="phpmain' .
$phpmain_hash . '" frameborder="1" />' . "\n";

Discussion

  • Garvin Hicking

    Garvin Hicking - 2003-05-28

    Logged In: YES
    user_id=473563

    Virgile,

    thanks a lot for your report. The bugfix has just been
    implemented into CVS!

    Regards,
    Garvin.

     
  • Garvin Hicking

    Garvin Hicking - 2003-05-28
    • priority: 5 --> 1
    • summary: 2.5.1-rc1 frame --> (in 2.5.1) 2.5.1-rc1 frameset generation
    • status: open --> open-fixed
     
  • Alexander M. Turek

    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed