#4816 (ok 4.5) Tiny localization issue in <database> --> Operations window

[Christophe Jaillet]

In the <database> --> Operations window, the ":" after "Collation" should be included in the text itself, as done for "Rename database to:" and "Copy database to:" or completely removed, as in "Create table" or "Remove table". The 2nd option looks more logical to me.
This will help translation (in French, there is a space before the ":")

Moreover, I don't really see the point of having a <label> for this title.

[Anshuman Verma]

I have fixed the localization issue in the commit by removing the ":" - https://github.com/Anshu-xLR/phpmyadmin/commit/258af1ae556c87f9e0d4133149ca18935d0ec4bb

[Isaac Bennetch]

Hi @anush-xlr, normally we prefer receiving code contributions as a pull request. Once you've made your commit and pushed it to your github repo (which you've already done), it's pretty easy to submit a pull request in just a few clicks through the interface.

Additionally, your commit does not appear to have a "signed-off-by" statement indicating you agree with our DCO (https://github.com/phpmyadmin/phpmyadmin/blob/master/DCO), which is necessary from a legal perspective to indicate that your code is compatible with our license.

You can see also http://www.phpmyadmin.net/home_page/devel.php and the wiki for more information.

Thanks and regards,
isaac

[Anshuman Verma]

Thanks @ibennetch for the guidance. I have done the necessary changes as requested by you and sent a Pull Request.

[Isaac Bennetch]

Yeah, this is a marginal use of the colon and an interesting question about whether headings should or should not have a colon. I think it belongs on this page because the heading serves as the label for the following text fields.

Regardless of whether we keep or remove the colon, it clearly should be part of the translatable string, so we'll get that taken care of shortly.

Thanks for your suggestion!

[Marc Delisle]

One of the goals of having a label is to help blind people using a screen reader.

[Christophe Jaillet]

Ok, but why only for this field then?

[Marc Delisle]

Other commits were done for the other labels.