Menu

#4803 (ok 4.3.13) "Show hidden items" is sometimes hidden

4.3.12
fixed
None
Low
2015-03-29
2015-03-13
No

Let's say you have a database group (for example, databases a_a and a_b) which are represented under a group "a" in the navi panel.

If you use the "hide" dimmed lightbulb icon to hide one of the tables inside of these databases, it gets hidden correctly but the yellow lightbulb icon "Show hidden items" does not appear next to the database name.

Discussion

  • pratik

    pratik - 2015-03-14

    The $_hiddencount variable in Node_Database.class.php always remains 0 for the databases (a_a and a_b) in the database group (a).

     
  • Deven Bansod

    Deven Bansod - 2015-03-15

    Hi Pratik,

    I would like to work on this if you have not started already. Just let me know if you are.

    Hi Marc,
    Basically, while grouping the nodes, we transfer the properties from $child to $new_child. But here we don't transfer the $_hiddencount attribute.

    Moreover, the $_hiddencount attribute is private for a Database node and thus we would require a get method in Node_Database class and we already have a set method and if we set it for the $new_child, then we are done.

    Please suggest changes and I will submit a pull request.

     

    Last edit: Deven Bansod 2015-03-15
    • pratik

      pratik - 2015-03-15

      Sure Deven..Please go ahead with it!

       

      Last edit: pratik 2015-03-15
  • Marc Delisle

    Marc Delisle - 2015-03-16
    • assigned_to: Marc Delisle
     
  • Marc Delisle

    Marc Delisle - 2015-03-16
    • summary: "Show hidden items" is sometimes hidden --> (ok 4.3.13) "Show hidden items" is sometimes hidden
    • status: open --> pending
    • Group: 4.3.11 --> 4.3.12
    • Priority: Normal --> Low
     
  • Marc Delisle

    Marc Delisle - 2015-03-16
    • status: pending --> resolved
     
  • Marc Delisle

    Marc Delisle - 2015-03-29
    • Status: resolved --> fixed