Menu

#4667 (ok 4.3.4) Consistency in borders

4.3.3
fixed
None
1
2014-12-29
2014-12-23
No

Browse table isn't consistent with Structure table

https://sourceforge.net/p/phpmyadmin/bugs/4648/

Discussion

  • Marc Delisle

    Marc Delisle - 2014-12-23
    • assigned_to: Hugues Peccatte
     
  • tapanhalani

    tapanhalani - 2014-12-23

    I am new to open-suorce development and to phpmyadmin. Please tell me how should I test this bug?And where should I edit the code to resolve it? Do I have to make changes in my local master branch?

     
  • Marc Delisle

    Marc Delisle - 2014-12-23

    tapanhalani, please read my comment above. I believe that the bug has been fixed.

     
    • tapanhalani

      tapanhalani - 2014-12-23

      I believe you are right. Sorry about not being clear about my question. I
      have been trying to test many bugs, but i couldn't. I asked other people
      about it . They told me that the bugs are on the master branch, so I have
      to test it there. I just want to clarify whether thay were referring to my
      local master branch or not? And if i change any code my local master
      branch, how could i see its effect on gui?
      Please forgive me for such beginner level doubts. But I am really desperate
      to do real good development.

      Thank you

       

      Last edit: Marc Delisle 2014-12-24
      • Marc Delisle

        Marc Delisle - 2014-12-23

        Hi,
        have a look at
        https://wiki.phpmyadmin.net/pma/Developer_guidelines#Branches_in_Git.
        About bug 4667, Milestone is marked "4.3.3" so most likely it's a bug happening on the 4.3.3 release. Bugfix for this is done on the QA_4_3 branch, for a future 4.3.4 release. Then, the fix is merged to the master branch for a future version.

        You probably have read
        http://www.phpmyadmin.net/home_page/devel.php.
        Then, if you cloned our repository, you have a copy of the code and you can do you testing on your repository, doing a "git checkout" for the branch you want to test.

        To see the effect on the GUI, well, it's difficult to reply without knowing your development environment. The trick is to have a web server document directory in which you installed the git repository. Then when you visit this directory via http, you are running phpMyAdmin from the repository.

         
        • tapanhalani

          tapanhalani - 2014-12-24

          Thank you Marc for your help. Regarding my development environment, i have
          cloned the forked git repository in my home directory in ubuntu 14.04 lts
          and to access the gui, i browse the local directory in Google Chrome
          browser through url:- https://localhost/phpmyadmin through browser tab.
          I tried making changes in php files stored in
          home/phpmyadmin/libraries/.php files. But those changes are not reflected
          in the GUI accessed like I shown above.

          Again thanks for your support.

          Thank you,
          Tapan Halani

           

          Last edit: Marc Delisle 2014-12-24
          • Marc Delisle

            Marc Delisle - 2014-12-24

            Tapan,
            this discussion should happen on the phpmyadmin-devel mailing list. As a quick answer, your results mean that you should not clone the repository in your home directory, but in the directory used by the web server when accessing phpmyadmin. Your question should be directed to http://serverfault.com

             
  • Marc Delisle

    Marc Delisle - 2014-12-24
    • summary: Consistency in borders --> (ok 4.3.4) Consistency in borders
    • status: open --> resolved
    • Priority: 5 --> 1
     
  • Marc Delisle

    Marc Delisle - 2014-12-29
    • Status: resolved --> fixed