Some columns have vertical borders and some don't. Is this intentional?
BTW, the tooltip for the keys could be more descriptive than "Unique". For example "Add unique index".
Olaf, I sent a PR for this ticket: https://github.com/phpmyadmin/phpmyadmin/pull/1426 Could you please confirm that the borders disappear? Thanks.
Hugues, as I understand this ticket, Olaf would like the missing borders to appear; maybe Olaf can confirm.
Oh… I just understood that this is not homogeneous. That's why, arbitrarily, I chose to remove them, except from table headers.
It should be consistent, I'm not sure whether borders or no borders would be better.
If we want to be consistent with table Browse, borders are needed.
Does it mean that the current PR could be deleted in favour of a new one displaying the borders like the Browse table please?
At least, that's my opinion but like Olaf I don't have a strong opinion about this.
No borders might be a bit more modern.
Pull request accepted (borders removal). Thanks.
As you said, to be more consistent, should we also remove borders on Browse table?
Good point.
BTW, the tooltip for the keys could be more descriptive than "Unique". For example "Add unique index".
Olaf,
I sent a PR for this ticket: https://github.com/phpmyadmin/phpmyadmin/pull/1426
Could you please confirm that the borders disappear?
Thanks.
Hugues,
as I understand this ticket, Olaf would like the missing borders to appear; maybe Olaf can confirm.
Oh… I just understood that this is not homogeneous.
That's why, arbitrarily, I chose to remove them, except from table headers.
It should be consistent, I'm not sure whether borders or no borders would be better.
If we want to be consistent with table Browse, borders are needed.
Does it mean that the current PR could be deleted in favour of a new one displaying the borders like the Browse table please?
At least, that's my opinion but like Olaf I don't have a strong opinion about this.
No borders might be a bit more modern.
Pull request accepted (borders removal). Thanks.
As you said, to be more consistent, should we also remove borders on Browse table?
Good point.