#4646 Version Check Broken

[Olaf van der Spek]

Version information: 4.3.2, latest stable version: 4.3.2
A newer version of phpMyAdmin is available and you should consider upgrading. The newest version is 4.3.2, released on 2014-12-12.

[Hugues Peccatte]

Did you get pMA from Git please? Which branch or tag did you get?
Do you always have this message please?
Thanks.

[Olaf van der Spek]

No, I used the .bz2 download.

[Hugues Peccatte]

Do you always have this message please or only once or sometimes?
If sometimes, did you find something to reproduce this?

[Alexander Kamp]

This issue does also occur in previous versions which having a version check. I experience it often because I leave my tabs open for a long time and updating PMA files frequently. After updating it doesn't recognize newest version directly.

My workaround is to force-reload PMA (Ctrl+F5).

Version check on index.php is in PHP-code (which is always correct), JSON version check uses variable pmaversion from messages.js which is not updated until window refresh. Fix for this issue is to add attribute to #li_pma_version element and reading version from there.

[Madhura Jayaratne]

Thanks Alexander.
Fix: https://github.com/phpmyadmin/phpmyadmin/commit/fefb11eb87cf0376a4071a60581f611f94a1ebcb

[Alexander Kamp]

You're welcome!

Side note: after update you have to reload window because current script removes span-blocks. But it will occur just once. That's why I suggested the attribute way, but after code review (PMA_printListItem is not capable to add extra data attributes) it's better this way.

[Olaf van der Spek]

Still broken:
Version information: 4.3.4, latest stable version: 4.3.4
A newer version of phpMyAdmin is available and you should consider upgrading. The newest version is 4.3.4, released on 2014-12-29.

[Olaf van der Spek]

Shouldn't the first bit say "Version information: 4.3.4 (up to date)" ?

[Madhura Jayaratne]

Do you still see this after clearing the cache?

[Olaf van der Spek]

No, now it shows the right info.

[Olaf van der Spek]

I should NOT have to clear my cache. Could this issue be reopened?

[Madhura Jayaratne]

Clearing the cache is required only once if you are upgrading from a pre 4.3.3 version to 4.3.3 or later. From there onwards no cache clearing should be required when upgrading for version check to work. So, in my view this is fixed.

[Olaf van der Spek]

I just did 4.3.6 -> 4.3.7 and it wasn't fixed.

[Madhura Jayaratne]

You probably meant 4.3.5 -> 4.3.6. AFAIK we haven't released 4.3.7 yet.
I did 4.3.5 -> 4.3.6 and it seems to work. However, I tested using GIT and by checking out the respective versions.

[Olaf van der Spek]

Oops, you're right.

[Madhura Jayaratne]

Tried with released versions and still unable to recreate. Is anyone else able to recreate?

[Isaac Bennetch]

Unfortunately I am also unable to reproduce this.

[Olaf van der Spek]

See screenshot. Both the warning at the bottom and the version display at the right seem to think there's an update, even though at the right you can see current == latest.

[Alexander Kamp]

The only way to resolve this error is to determine the input values for comparison '(latest > current)' in PMA_current_version. Perhaps there is an error in method parseVersionString - or it receives invalid information. My way to investigate this is to add the following - file js/functions.js:

Before row 245:

    input_str =   $('span.version').text();
    console.log("Current (input="+typeof(input_str)+"): '"+input_str+"'");
    console.log("Latest (input="+typeof(data.version)+"): '"+data.version+"'");

After 'parseVersionString' function calls:

    console.log("Current:");
    console.log(current);
    console.log("Latest:");
    console.log(latest);

In the situation the error appears, you can open Chrome console (Right click, Inspect Element, tab Console).

Preview what it should output (attached):