#4454 (ok 4.2.4) PMA_DatabaseInterface::getColumnsFull() when called with no database or table parameter gives incorrectly nested keys.

[Chirayu Chiripal]

PMA_DatabaseInterface::getColumnsFull() when used with empty database or table name causes the few keys to be incorrectly nested. For e.g.

$output = $GLOBALS['dbi']->getColumnsFull();

The $output here returns array something like this: http://pastebin.com/Ca4721yJ
i.e.

[database_name_1] => array(
    [table_name_1] => array(
        [Column_name_1] => array(
            'Field' => [value],
            'TABLE_NAME' => [value],
            'COLUMN_NAME' => [value],
            ... // and other column properties
        )
    // Below part has problems
    'Field' => [value],
    'TABLE_NAME' => [value],
    ... // and other column properties are being added at table level 
        // causing problems to get table names properly. 
        // Also, if there is a table named 'Field' or 'TABLE_NAME'
        // then the output gets more wierd.

• It only works fine if both database and table name is given.
• The code which is adding those keys have been documented as to be removed ( https://github.com/phpmyadmin/phpmyadmin/blob/QA_4_2/libraries/DatabaseInterface.class.php#L1111 onwards).
• I have checked the places where it has been used and currently all calls to the function have specified database & table name, causing this issue to remain unnoticed.

[Chirayu Chiripal]

I am not sure whether the fix should go to QA_4_2 or master branch.

[Chirayu Chiripal]

PR (Sent to QA_4_2): https://github.com/phpmyadmin/phpmyadmin/pull/1223

[Michal Čihař]

Fix merged.