Menu

#4264 (ok 4.1.7) Uncheck "Ignore" while inserting, upon leaving a textarea

4.1.6
fixed
1
2014-02-09
2014-01-30
No

While inserting, the Ignore checkbox is on for all but the first entry. They are gradually unchecked as you start filling the fields for their corresponding entries.

Except this does not work for textareas in dynamically added rows. It works in the second row (which was already there on pageload), but when you use "restart with 5", the next ones do not work. Note: I've only seen it fail on textareas; for normal textfields it does work.

For testing: create a table with just a VARCHAR(255). Go to the insert interface, 'restart with 5', and fill something in for each row. Watch the "Ignore" checkbox clearing on the second row, but not the rest.

I'm assuming it's a ".bind()" instead of ".on()" issue in some javascript file.

Discussion

  • Marc Delisle

    Marc Delisle - 2014-01-31
    • assigned_to: Marc Delisle
     
  • Marc Delisle

    Marc Delisle - 2014-01-31

    Please confirm this patch:

    diff --git a/js/tbl_change.js b/js/tbl_change.js
    index 3785383..8d4acfe 100644
    --- a/js/tbl_change.js
    +++ b/js/tbl_change.js
    @@ -388,7 +388,7 @@ AJAX.registerOnload('tbl_change.js', function () {
    var hashed_field = name_parts[1].match(/[(.+)]/)[1];
    $this_element.attr('name', new_name);

    • if ($this_element.is('.textfield')) {
    • if ($this_element.is('.textfield') || $this_element.is('.char')) {
      // do not remove the 'value' attribute for ENUM columns
      if ($this_element.closest('tr').find('span.column_type').html() != 'enum') {
      $this_element.val($this_element.closest('tr').find('span.default_value').html());
     
  • Joris Debonnet

    Joris Debonnet - 2014-02-01

    That fixes it indeed!

     
  • Ann + J.M.

    Ann + J.M. - 2014-02-03
    • labels: --> interface, javascript
    • summary: Uncheck "Ignore" while inserting, upon leaving a textarea --> (ok 4.1.7) Uncheck "Ignore" while inserting, upon leaving a textarea
    • status: open --> resolved
    • Priority: 5 --> 1
     
  • Marc Delisle

    Marc Delisle - 2014-02-09
    • Status: resolved --> fixed