(ok 4.1.0-rc1) Footer not included in AJAX loaded pages

A software tool to bring MySQL to the Web

Brought to you by: ibennetch, nijel

#3967 (ok 4.1.0-rc1) Footer not included in AJAX loaded pages

Milestone: Latest_Git

Status: fixed

Owner: Atul Pratap Singh

Labels: None

Priority: 1

Updated: 2013-12-12

Created: 2013-06-05

Creator: Michal Čihař

Private: No

The file config.footer.inc.php is included only in first page loaded, further ones loaded by AJAX do not include it.

Related

Bugs: ~~#4050~~

Discussion

Marc Delisle - 2013-11-12

status: open --> pending

assigned_to: Marc Delisle
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2013-11-12

Michal,
cannot reproduce with current master (1e64844537e7d6de64e85cce302407daa4e4fab7), or current QA_4_0 (46f88bab6bda180f55709e96f96ad28072794677).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2013-11-13

status: pending --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2013-11-13

Still reproducible for me on master (1955d5e), haven't tested other.

To reproduce:

Put some text to config.footer.inc.php

Load main page, verify it contains the text at bottom

Load another tab, eg. SQL, it does not contain the text
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2013-11-13

Michal,
cannot reproduce with your exact scenario. I only put plain text in config.footer.inc.php and am running PHP 5.5.3.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Supun Nakandala - 2013-11-13

Hi Marc,
I was also not able to regenerate this error. I tested it with master(1955d5e) and QA_4.0(cbc620e) and I am using php 5.3.5

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2013-11-13

Okay, the text needs to be in some HTML tag to disappear. If there is just text it works, when there is <p>text</p> it does not.

Last edit: Michal Čihař 2013-11-13

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2013-11-13

assigned_to: Marc Delisle --> nobody
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Atul Pratap Singh - 2013-11-14

assigned_to: Atul Pratap Singh
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Atul Pratap Singh - 2013-11-14

Michal,
I could reproduce it, please review https://github.com/phpmyadmin/phpmyadmin/pull/754

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2013-11-14

summary: Footer not included in AJAX loaded pages --> (ok 4.1) Footer not included in AJAX loaded pages

status: open --> resolved

Priority: 5 --> 1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2013-11-14

Merged pull request.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2013-11-14

summary: (ok 4.1) Footer not included in AJAX loaded pages --> (ok 4.1.0-beta3) Footer not included in AJAX loaded pages
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2013-11-23

summary: (ok 4.1.0-beta3) Footer not included in AJAX loaded pages --> (ok 4.1.0-rc1) Footer not included in AJAX loaded pages
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2013-12-12

Status: resolved --> fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: