#3965 (ok 4.0.4) Default language wrong with zh-TW

[benck]

Default accept-language for Chrome on a traditional Chinese Windows machine is:

Accept-Language:zh-TW,zh;q=0.8,en-US;q=0.6,en;q=0.4

However, the default language selected by phpMyAdmin is simplified Chinese which is wrong. I think there is something wrong in the file: select_lang.lib.php.

[benck]

I further examined the code in the file select_lang.lib.php. The problem is in PMA_langDetect().

In this loop

foreach ($GLOBALS['available_languages'] as $lang => $value)

"zh_CN" is iterated before "zh_TW" in array $GLOBALS['available_languages']. However, the regexp for "zh_CN" does not contain "_CN" so it does match "zh-TW".

I recommend to make the regexp string for "zh_CN" from

'zh|chinese simplified'

to

'zh(?![-_](tw|hk))([-_][[:alpha:]]{2,3})?|chinese simplified'

in function PMA_langDetails().

The new regexp matches all languages starting with zh but not zh_TW or zh_HK which is correct in real world. Only TW and HK use traditional Chinese while others (CN, SG, MY) use simplified one.

[Marc Delisle]

Thanks, your solution was implemented for 4.0.4.