#3917 CountTables seems broken

[Isaac Bennetch]

It seems as if the CountTables configuration option doesn't work anymore.

Git tells me the first bad commit was 69b81e "Added ajax-loaded navigation to the main page" by Rouslan, although I got a blank page during my git bisect so wasn't able to test that particular revision.

[Isaac Bennetch]

Originally reported here: https://sourceforge.net/p/phpmyadmin/discussion/Help/thread/90a9cf39/

[Jordan Fernando]

I try to fix this, please review.
Pull request: https://github.com/phpmyadmin/phpmyadmin/pull/353

[Rouslan Placella]

I deliberately removed display of the number of tables in version 4.0. The queries are already very slow as they are. The rationale was that the navigation is for navigating, not gathering information about the databases.

If that's the only place where that config option is used, I'd rather see that removed instead...

[Isaac Bennetch]

That makes sense, but a user was asking about it so I wonder how many people would miss it. Since that code is currently removed, probably the best solution is to remove that configuration option and associated documentation, plus document the depreciation in the release notes. It's not something I feel strongly about keeping or removing.

[Madhura Jayaratne]

I also agree that CountTables configuration should be dropped.

[Marc Delisle]

Please review https://github.com/phpmyadmin/phpmyadmin/pull/398.

Update: this pull request has been implemented, removing the CountTables directive.

[Madhura Jayaratne]

I've edited wiki to reflect the deprecation. http://wiki.phpmyadmin.net/pma/Config/Servers#CountTables