#3895 (ok 4.0.1) Multiple errors trying to vew BLOB data

[Isaac Bennetch]

Hi,

The error messages are:
tbl_get_field.php: Missing parameter: where_clause
tbl_get_field.php: Missing parameter: transform_key

To reproduce: Create a table with an autoincrementing 'id' and a longblob 'picture', upload an image to 'picture', go to the Browse tab and click on the text similar to "[BLOB - 1.9 MiB]". The error text appears as an AJAX dialog.

According to my attempt at git bisect, the error message is a recent change but the expected behaviour has been silently broken since [db22f56fd2584508bc77cb03922020183ac8bb49] Document MaxRows behavior when a LIMIT clause is present...but that commit doesn't look suspicious at all, so I seem to have had some glitch when bisecting. At the very least I can at least report that QA_3_5 does not generate the error (it does want to download the .jpg as a .bin file instead, but I did not investigate that further); current master d359426f536303aa303d7bfcfbdbf430b2f87b97 gives the error message.

[Isaac Bennetch]

• Description has changed:

Diff:

--- old
+++ new
@@ -1,7 +1,7 @@
 Hi,

 The error messages are:
-tbl_get_field.php: missing parameter: where_clause
+tbl_get_field.php: Missing parameter: where_clause
 tbl_get_field.php: Missing parameter: transform_key

 To reproduce: Create a table with an autoincrementing 'id' and a longblob 'picture', upload an image to 'picture', go to the Browse tab and click on the text similar to "[BLOB - 1.9 MiB]". The error text appears as an AJAX dialog.

[Abhishek Kandoi]

I was looking into this bug and I found out that the $GLOBALS variable array is checked for the existence of the two elements $GLOBALS['where_clause'] and $GLOBALS['transform_key'] by the PMA_Util::checkParameters function. But for some reason these elements are not set.

Can you provide me some help on where is the $GLOBALS variable set so that I can work further on this bug.

[Marc Delisle]

In previous versions, we had a script that took all POST and GET variables and created globals from them.
This has been replaced in each script that requires POST or GET variables, by either using them directly (most often via $_REQUEST), or doing a for loop on a list of expected variables.

$GLOBALS is an array that refers to all global variables.

[Jan Brejcha]

Hello, I would like to try to work on it. I have time for it till next sunday. Is it possible, or is someone else going to fix it?

[Abhishek Kandoi]

I am trying to fix this bug. Maybe you should try fixing another one so as to avoid double working on the same bug.

[Jan Brejcha]

Ok, I will try to find something else. Thank you very much!

[Michal Čihař]

Fixed in git by https://github.com/phpmyadmin/phpmyadmin/pull/302