Menu

#3875 (ok 4.0.0-rc2) Lost location hash and token on table add field

4.0.0
fixed
None
1
2013-06-11
2013-04-13
No

Steps:

  1. Open a table, switch to "Structure" tab.
  2. In the "Add columns" section, enter a number of rows > 1, click "Go".
  3. Fill in some demo names for the columns, click "Save".

Expected:
Fields are added via AJAX, top navbar works as usual.

Actual:
Fields are added via legacy form-submit, top navbar is then broken.
Token is lost (URL is set to "tbl_addfield.php" with no query string).

Discussion

  • Ayush Choubey

    Ayush Choubey - 2013-04-14

    Are we allowed to make a couple of changes in the form properties? because the we get the class name of the form as "append_fields_form ajax" (from tbl_columns_defination_form.inc.php) which is not the selector's name in the handler part of jquery in tbl_structure.js. That's why i asked if i can make changes in form?

    Well i have made the code and and it seems to be working fine. If i change the names do i have to tell anywhere in the code that previous name was "this" and i changed to "this new name". And do i have to push the changes in master branch i.e. 4.1 or for 4.0.0-rc1 ?

    Sorry to bother with the questions, i am newbie and don't know all the rules

     
  • Madhura Jayaratne

    • summary: Lost location hash and token on table add field --> (ok 4.0.0-rc2) Lost location hash and token on table add field
    • status: open --> open-fixed
    • assigned_to: Madhura Jayaratne
    • Priority: 5 --> 1
     
  • Marc Delisle

    Marc Delisle - 2013-05-03
    • Status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed