#3687 (ok 3.5.4) Display chart and number of rows

3.5.3
fixed
1
2013-06-11
2012-09-26
No

tbl_chart.php fetches the whole data set generated by the query and puts it into an array. Then, this is passed to the js level for chart generation. Evidently, the web server's process and the browser itself hit memory limits, even for medium tables (sakila.film_actor).

I'm not sure what the user expects when clicking on "Display chart" in terms of the number of rows, because, for example "Query results operations>Print view" only displays the current rows on screen (30 by default).

So I suggest to do something similar to what was done in Search>Zoom search: to have in the chart interface a control for the maximum number
of rows, with 500 as the default value.

Discussion

  • Atul Pratap Singh

    Marc,
    Should we put a field like "Max rows to plot" and a "Go" button on the display chart page. And by default we could use current rows on the screen, after which user could alter number of rows and click "Go".

     
  • Atul Pratap Singh

    • assigned_to: nobody --> atul5
     
  • Marc Delisle

    Marc Delisle - 2012-10-21

    Atul,
    this is a good idea; it implies that no chart would be generated before clicking on Go, which is fine and would solve an implementation problem I had, with my initial tests with this.
    Please reuse the existing "Maximum rows to plot" message.
    I wonder what's better, using the current number of rows on screen, or seed the input field with the value from $cfg['maxRowPlotLimit'].

     
  • Madhura Jayaratne

    How about using 'Start row' and 'no of rows', just like in the table browse page. That way the user should be able to plot the last rows without hitting memory limits. And we can directly take the set of rows the user was viewing at the browse page to the chart page. E.i. if the user was viewing 30 rows starting from 120 when clicking on the display chart link, we can set the same initial values in the chart page.

     
  • Marc Delisle

    Marc Delisle - 2012-10-22

    Madhura,
    yes this makes sense.

     
  • Atul Pratap Singh

    Thanks Madhura, I'll proceed with "Start row" and "Number of rows", and we plot the chart only after "Go" click.

     
  • Atul Pratap Singh

    • priority: 5 --> 1
    • summary: Display chart and number of rows --> (ok 3.5.4) Display chart and number of rows
    • status: open --> open-fixed
     
  • Atul Pratap Singh

    Thanks for reporting, fixed for 3.5.4.

     
  • Marc Delisle

    Marc Delisle - 2012-11-16
    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed