#3591 (ok 4.0) Firefox bug in SQL tab

Latest_Git
fixed
Interface (555)
1
2013-06-11
2012-05-07
No

I've spotted what seems to be an unusual bug in sql.js.

Steps to reproduce:

* Open firefox
* Open firebug console
* Go to main.php
* Click on the SQL tab
* Enter this query: USE somedb
* Click "Go"

At this point your firebug console should be busy displaying a dozen of requests for JS files which are totally unnecessary and the database that you attempted to select has not been selected for you.

Now, onto the interesting part, git-bisect says that the bug comes from commit 44364aae1bf51847744b53dfc773ad0415efba6b.
The commit itself looks quite harmless, but somehow it manages to break this functionality.
In fact, if in current master you replace 'isAddClass' on lines 549 and 562 back to 'class', the issue disappears.

As far as I can see, this issue is only present in Firefox (I'm using version 12.0).
I tested Chromium 18.0 and IE 8, however they do not have this issue.

Discussion

  • Marc Delisle

    Marc Delisle - 2012-12-04

    In current master, I get in js/navigation.js, line 407:

    TypeError: elms is undefined
    if (elms.$content.height() > $(window).height()) {

     
  • Marc Delisle

    Marc Delisle - 2012-12-13

    Tested in master as of 8428d7d55055cae5ca5f1d0ea493d11e44dac682.

    With Firefox when trying "USE sakila" (I have the sakila db), I get three CodeMirror boxes and the db is not selected. I no longer see the navigation.js error I mentionned.

    With IE8, I get one CodeMirror box and the db is still not selected.

     
  • Atul Pratap Singh

    • assigned_to: Atul Pratap Singh
    • milestone: 3.5.1 --> Latest_Git
     
  • adam_china

    adam_china - 2013-04-06

    Hi,
    I don't see any console output on both firefox and Chrome now.

    Adam

     
  • Atul Pratap Singh

    • summary: Firefox bug in SQL tab --> (ok 4.0) Firefox bug in SQL tab
    • status: open --> open-fixed
    • Priority: 5 --> 1
     
  • Marc Delisle

    Marc Delisle - 2013-05-03
    • Status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks