(ok 3.5.1) Version check not working (https)

A software tool to bring MySQL to the Web

Brought to you by: ibennetch, nijel

#3463 (ok 3.5.1) Version check not working (https)

Milestone: 3.4.3

Status: fixed

Owner: Michal Čihař

Labels: Interface (555)

Priority: 1

Updated: 2013-06-11

Created: 2011-10-20

Creator: the_Code_Guy

Private: No

The "Version check" functionality (Settings->Features) - which enables check for latest version on main phpMyAdmin page - hasn't been working since the early release of 3.4.

My current version of phpMyAdmin 3.4.3.2.

I checked and searched the bug list as well as the release notes for 3.4.6 but saw nothing related to this issue. However, installing 3.4.6 would be meaningless as it's the latest version. I think because it only worked on the first release of 3.4, no one possibly new it existed.

Discussion

Marc Delisle - 2011-10-20

Works fine for me, for example I see "Version information: 3.4.3.2, latest stable version: 3.4.6".

Version check uses Javascript, I expect it's active in your browser.
Which browser are you using?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2011-10-20

status: open --> pending
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

the_Code_Guy - 2011-10-20

status: pending --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

the_Code_Guy - 2011-10-20

I'm using Firefox (7.0.1) and yes, Javascript is active.

I'm probably 2-3 versions behind the current one (not getting reminded I'm not current ;-) ) - Was this fixed recently? It only worked for me on the first 3.4 release and hasn't since.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2011-10-20

What do you mean, fixed recently? I am trying with version 3.4.3.2, like yours, with Firefox 7.0.1 (on Windows XP) and I get the correct message.

Look in libraries/vendor_config.php, the value of VERSION_CHECK_DEFAULT.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

the_Code_Guy - 2011-10-21

What do think I meant by "fixed recently?"

Here's the value in my libraries/vendor_config.php

define('VERSION_CHECK_DEFAULT', true);

I guess I'll just have to determine the version the old fashioned way. Not a big deal. :-(

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2011-10-22

I was wondering about "fixed recently", because I had confirmed to you that with the same version as you are using, it works.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2011-10-23

status: open --> pending-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

the_Code_Guy - 2011-10-24

sorry, offline this weekend...

Yes, we have the same version but I'm not seeing the new version string that appears normally at the bottom of the pkpMyAdmin page when the current version is out of date.

Regarding the "Fixed Recently" I was wondering if was fixed since 3.4.3.2 but if you're seeing it in the same version as me, then it might be an obscure bug. Strange one...

Thanks

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

the_Code_Guy - 2011-10-24

status: pending-works-for-me --> open-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2011-11-02

status: open-works-for-me --> closed-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

the_Code_Guy - 2012-01-11

Finally figured out why the "A newer version of phpMyAdmin is available..." string wasn't appearing...

It doesn't appear if your server is on a secure website which, I would assume, it should.

It works for http://sitename/phpmyadmin but not for https://sitename/phpmyadmin.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2012-01-15

status: closed-works-for-me --> open-works-for-me
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2012-01-15

status: open-works-for-me --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2012-01-15

Confirmed for https.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

the_Code_Guy - 2012-01-18

Marc, what version are you currently running. If this works for you but doesn't work for me, then it's an issue - or, at least, some other underlying issue.

What else could prevent the "Version Check" from appearing on the https page but show on the http page.

Can I send you a screen shot because it seems you just don't believe me?

I'm just trying to figure out why this is happening and I'm concerned how, if I have an issue that is reproduce able, is simply brushed aside by you.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2012-01-18

I meant "Bug confirmed when using https".

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2012-02-18

summary: Version check not working --> Version check not working (https)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Jan Pecek - 2012-04-15

I've send pull request (https://github.com/phpmyadmin/phpmyadmin/pull/34) to improve solving this bug. There is still problem with some browsers (for detail description let show pull request).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2012-04-16

Merged pull request and backported to QA_3_5. For now version check is disabled only for IE.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2012-04-16

summary: Version check not working (https) --> (ok 3.5.1) Version check not working (https)

assigned_to: nobody --> nijel

priority: 5 --> 1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2012-05-07

status: open-accepted --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2013-06-11

Status: closed-accepted --> fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link: